refactor(test-benchmark): centralize benchmark helper utilities#3166
Merged
spencer-tb merged 9 commits intoJul 15, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## devnets/glamsterdam/6-benchmarks #3166 +/- ##
===================================================================
Coverage ? 93.30%
===================================================================
Files ? 624
Lines ? 36986
Branches ? 3383
===================================================================
Hits ? 34508
Misses ? 1695
Partials ? 783
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
spencer-tb
approved these changes
Jul 15, 2026
spencer-tb
left a comment
Contributor
There was a problem hiding this comment.
Refactor is clean. Easy to approve here!
spencer-tb
merged commit Jul 15, 2026
f598615
into
ethereum:devnets/glamsterdam/6-benchmarks
19 checks passed
This was referenced Jul 16, 2026
marioevz
pushed a commit
that referenced
this pull request
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Consolidates the three scattered
helpers.pymodules (tests/benchmark/compute/helpers.py,tests/benchmark/stateful/helpers.py, and the shared parts oftests/benchmark/stateful/eip7928_block_level_access_lists/helpers.py) into the existing shared packagetests/benchmark/helper/, organized by domain:numeric.pyneg,sar,make_dup,DEFAULT_BINOP_ARGS, …)enums.pyStorageAction,ReturnDataStyle,CacheStrategy,TransactionResult)loops.pyDECREMENT_COUNTER_CONDITION)precompile.pyPrecompileopcode targets,calculate_optimal_input_lengthcontract_factory.pyCustomSizedContractInitcode/CustomSizedContractFactory,ContractDeploymentTransactiontransactions.pybuild_benchmark_txs,pack_transactions_into_blocks,build_cache_strategy_blocksstorage.pyStorageInitRange,build_sequential_storage_init, calldata/access-list generatorsdelegation.pyrun_bloated_eoa_benchmarknumeric,enums)loops,precompile,contract_factory,transactions,storage,account_creator,account_sender_receiverdelegationCleanups included in the PR:
CallDataOrigin,concatenate_parameters(also drops the cross-suitetests.osakaimport it required),ALLOWANCE_SELECTOR,MINT_SELECTOR.test_erc20.py, their only consumer.No test logic changes within this PR, only code refactor.
Related Issues or PRs
Issue #2625
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture