refactor(tests): enhance EIP-8037 test coverage part 3 - #3485
Merged
marioevz merged 2 commits intoSep 1, 2026
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## forks/amsterdam #3485 +/- ##
================================================
Coverage 93.90% 93.90%
================================================
Files 624 624
Lines 36905 36905
Branches 3326 3326
================================================
Hits 34655 34655
Misses 1569 1569
Partials 681 681
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
LouisTsai-Csie
force-pushed
the
enhance-8037-pt3
branch
from
September 1, 2026 07:24
6450ee5 to
ba6814a
Compare
LouisTsai-Csie
marked this pull request as ready for review
September 1, 2026 07:29
marioevz
approved these changes
Sep 1, 2026
marioevz
left a comment
Member
There was a problem hiding this comment.
Awesome work on all of these changes, a lot of great detail and verification was added. I added a couple more variants to many of the tests in order to either verify test via an off-by-one variant, or verify both kinds of CREATE opcodes when possible (including the create collision test).
This was referenced Sep 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Part 3 of EIP-8037 state-gas test cleanup:
test_state_gas_create.py. No spec changes, no new behavior. All edits either pin claimed gas, fix opcode metadata, or clarify docstrings.Header(gas_used=...)andTransactionReceipt(cumulative_gas_used=...)with named assertions.init_code_size,new_memory_size,code_deposit_size,account_new,SSTOREvalues) that silently mis-priced budgets.execution_cost+state_cost(including 63/64 gross-up).gas_limit = cap + Xtostate_gas_reservoir;test_create_with_reservoiradds exact_fit / one_short.Related Issues or PRs
N/A.
Checklist
just static<type>(<area>): <title>, where<type>and<area>come from an appropriateC-<type>, respectivelyA-<area>, label. The title should match the target squash commit message.Cute Animal Picture