Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge internal_datasets into master #209

Merged
merged 30 commits into from
Dec 25, 2023
Merged

Merge internal_datasets into master #209

merged 30 commits into from
Dec 25, 2023

Conversation

ostreech1997
Copy link
Collaborator

Before submitting (must do checklist)

  • Did you read the contribution guide?
  • Did you update the docs? We use Numpy format for all the methods and classes.
  • Did you write any new necessary tests?
  • Did you update the CHANGELOG?

Proposed Changes

Closing issues

ostreech1997 and others added 26 commits August 29, 2023 13:38
* add M3 to internal_datasets

* add df_exog to m3 dataset

* minor fixes, add exog dir

* delete ssl

* minor fixs

* fix tests

* fix docs

* fix docs

---------

Co-authored-by: Egor Baturin <egoriyaa@github.com>
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

# Conflicts:
#	CHANGELOG.md
#	README.md
#	docs/source/conf.py
#	docs/source/user_guide.rst
#	examples/101-get_started.ipynb
#	examples/305-classification.ipynb
#	examples/README.md
Copy link

github-actions bot commented Dec 22, 2023

🚀 Deployed on https://deploy-preview-209--etna-docs.netlify.app

@github-actions github-actions bot temporarily deployed to pull request December 22, 2023 12:37 Inactive
CHANGELOG.md Outdated
-
-
-
- Change warning condition on loading object saved under different library version ([#31](https://github.com/etna-team/etna/issues/31))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure it should be here.

@@ -61,6 +61,7 @@
"sphinx.ext.mathjax", # render math via JavaScript
"sphinx.ext.githubpages", # creates .nojekyll file
"sphinx.ext.linkcode", # add external links to source code
"sphinx.ext.autosectionlabel" # add internal links in docs
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is better to write smth like "allow reference sections using its title"

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

Attention: 71 lines in your changes are missing coverage. Please review.

Comparison is base (8fa027e) 89.29% compared to head (9163f73) 89.03%.

Files Patch % Lines
etna/datasets/internal_datasets.py 77.24% 71 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #209      +/-   ##
==========================================
- Coverage   89.29%   89.03%   -0.27%     
==========================================
  Files         198      199       +1     
  Lines       12868    13181     +313     
==========================================
+ Hits        11491    11736     +245     
- Misses       1377     1445      +68     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@github-actions github-actions bot temporarily deployed to pull request December 22, 2023 13:18 Inactive
@github-actions github-actions bot temporarily deployed to pull request December 22, 2023 14:01 Inactive
CHANGELOG.md Outdated
- Add dataset integrity check using hash for internal datasets ([#151](https://github.com/etna-team/etna/pull/151))
- Add params_to_tune for DeepStateModel ([#115](https://github.com/etna-team/etna/issues/115))
- Handle new functionality for prediction intervals in the `plot_forecast` ([#130](https://github.com/etna-team/etna/pull/130))
- Add `get_historical_forecasts` to pipelines for forecast estimation at each fold on the historical dataset ([#143](https://github.com/etna-team/etna/pull/143))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed

CHANGELOG.md Outdated
- Add `list_datasets` function ([#145](https://github.com/etna-team/etna/pull/149))
- Add `IHEPC` to internal datasets ([#150](https://github.com/etna-team/etna/pull/150))
- Add dataset integrity check using hash for internal datasets ([#151](https://github.com/etna-team/etna/pull/151))
- Add params_to_tune for DeepStateModel ([#115](https://github.com/etna-team/etna/issues/115))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed

CHANGELOG.md Outdated
- Add params_to_tune for DeepStateModel ([#115](https://github.com/etna-team/etna/issues/115))
- Handle new functionality for prediction intervals in the `plot_forecast` ([#130](https://github.com/etna-team/etna/pull/130))
- Add `get_historical_forecasts` to pipelines for forecast estimation at each fold on the historical dataset ([#143](https://github.com/etna-team/etna/pull/143))
- `ConformalPredictionIntervals` method for prediction intervals estimation ([#152](https://github.com/etna-team/etna/pull/152))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed

CHANGELOG.md Outdated
- Handle new functionality for prediction intervals in the `plot_forecast` ([#130](https://github.com/etna-team/etna/pull/130))
- Add `get_historical_forecasts` to pipelines for forecast estimation at each fold on the historical dataset ([#143](https://github.com/etna-team/etna/pull/143))
- `ConformalPredictionIntervals` method for prediction intervals estimation ([#152](https://github.com/etna-team/etna/pull/152))
- Add DeepARNativeModel ([#114](https://github.com/etna-team/etna/pull/114))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line should be removed

@github-actions github-actions bot temporarily deployed to pull request December 22, 2023 15:21 Inactive
@ostreech1997 ostreech1997 merged commit d9bd506 into master Dec 25, 2023
16 checks passed
@ostreech1997 ostreech1997 deleted the internal_datasets branch December 25, 2023 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants