Input components

[mcrascal]

Breaks input components out of 1569

[changeset-bot]

🦋 Changeset detected

Latest commit: a51e5a3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages

Name	Type
@evidence-dev/core-components	Patch
@evidence-dev/evidence	Patch
@evidence-dev/components	Patch
evidence-test-environment	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 6, 2024 1:50am

[netlify]

✅ Deploy Preview for evidence-development-workspace ready!

Name	Link
🔨 Latest commit	a51e5a3
🔍 Latest deploy log	https://app.netlify.com/sites/evidence-development-workspace/deploys/65e7cbe790d9360008fcdd7f
😎 Deploy Preview	https://deploy-preview-1668--evidence-development-workspace.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[csjh]

I'm just noticing/remembering I never concluded the dropdown backwards compatibility fix

I'm leaning on the side of an includeLabels prop since it seems cleaner for everyone involved

[archiewood]

how would that work?

<Dropdown includeLabels=true/> allows

${inputs.my_input.value} and ${inputs.my_input.label}?

but
<Dropdown/>

only allows

${inputs.my_input}

[csjh]

yup

[archiewood]

Sounds like a good solution to me.

What do you think about warning a breaking change in the future?

${inputs.my_input} will be deprecated in later versions of evidence.

Use ${inputs.my_input.value} in combination with includeLabels=true

[csjh]

Yeah makes sense to me

[mcrascal]

@archiewood I'm inclined to just make the breaking change and announce it in the changelog

[archiewood]

That's fine. We should definitely add a major bump in that case