Fix releasing External IP when VM is deleted - #138
Merged
Conversation
slothkong
approved these changes
Jul 30, 2026
Contributor
|
Hey @pacospace, I ran an independent manual test of this feature, together with #97. Both features achieve their target. Note however that one of the two features (likely extra volume attachment) seem to have introduced a bug (see #139). The issue is minor, so I think is OR to proceed with this PR and deal with the regression separately. |
This was referenced Jul 30, 2026
ewc-semantic-releases Bot
pushed a commit
that referenced
this pull request
Aug 3, 2026
# [0.7.0](0.6.0...0.7.0) (2026-08-03) ### Bug Fixes * ECMWF region names ([#141](#141)) ([5358cf6](5358cf6)) * Fix tests and external ip deletion ([#142](#142)) ([560f769](560f769)) * GPU flavour and GPU image mismatch ([#136](#136)) ([1f3d4af](1f3d4af)) * Release External IP when VM is deleted ([#138](#138)) ([24a3513](24a3513)) ### Features * Expose message output after ewc infra delete command ([#135](#135)) ([2922164](2922164)) * Include links into help command ([#145](#145)) ([4f70a34](4f70a34)) * Introduce extra volume flag for servers ([#97](#97)) ([7331661](7331661)) * Show also keypair in ewc infra list command ([#134](#134)) ([d6d9173](d6d9173))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #69
Depends-On: #97