test: Mock resolve_machine_ip() to compensate for FakeServerInfo missing attr - #140
Closed
slothkong wants to merge 1 commit into
Closed
test: Mock resolve_machine_ip() to compensate for FakeServerInfo missing attr#140slothkong wants to merge 1 commit into
slothkong wants to merge 1 commit into
Conversation
Merged
Member
|
Thanks for this @slothkong, but this #142 covered also the issue you opened, so I think we can close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @pacospace,
The feature introduced in #138 brought in also a few broken unittests:
This PR addresses those 4 particular assertion failures.
What is new
resolve_machine_ip()directly in the four tests so they only exercise the volume-detach procedure you care about.Technical Note
FakeServerInfodoesn't totally mock the interface thatpre_delete_server/resolve_machine_ipexpect fromserver_info; it doesnt have a.get()method like the expecteddictdoes.A solution for the unittests would have also been to force
FakeServerInfoto have aget()method, but that ties the tests to the implementation details of the code, which in general not a good practice we can avoid in this case.