Fix AppHost startup args and expose client setup path - #2355
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f32a87734a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@ejsmith quick product naming check: this PR exposes the existing
Should we standardize this route as |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1611b606bc
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: daccbdcb5c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 831250ec10
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
This configuration is no longer required, simplifying the client setup process in both local development and Kubernetes deployments.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 43e7eec8ed
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| builder.Services.AddExceptionless(c => { | ||
| c.ApiKey = "${apiKey}"; | ||
| c.ServerUrl = "${serverUrl}"; |
There was a problem hiding this comment.
When PUBLIC_EXCEPTIONLESS_CLIENT_SETUP_SHOW_SERVER_URL is true, the ASP.NET Core setup sample now tells self-hosted users to configure the client via builder.Services.AddExceptionless(c => ...), but the configurable Exceptionless.AspNetCore overload is exposed on WebApplicationBuilder (builder.AddExceptionless(c => ...)), not on IServiceCollection. Copying this new self-hosted snippet into a minimal-host ASP.NET Core app fails to compile, so users cannot use the server URL setup path this change adds.
Useful? React with 👍 / 👎.
|
1 participant
Summary
--skip-trust-developer-certificate,--allow-unsecured-transport,--disable-dashboard) throughDistributedApplicationOptions.Testing
aspire runonce package restore can complete.Notes
.aspire-homeartifacts; only source changes are included.