Simplify sensitive startup logging - #2407
Merged
Merged
Conversation
ejsmith
marked this pull request as ready for review
July 27, 2026 21:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The
mainbuild failed after PR #2405 merged because the safe OAuth logging transformer manually duplicated everyOAuthServerOptionsproperty and did not includeRefreshTokenReuseGracePeriod, added by PR #2404.This change fixes the failure without requiring every ordinary option property to be copied into the logging implementation. New non-sensitive properties are logged automatically; new sensitive properties only need a redaction or sanitization rule.
Failed workflow: https://github.com/exceptionless/Exceptionless/actions/runs/30300072521
Verification
dotnet build --no-restore --configuration Debug(0 warnings, 0 errors)dotnet test --no-build -- --filter-class Exceptionless.Tests.Logging.SensitiveDataLoggingTests(5 passed)git diff --checkBreaking changes
None.