Skip to content

Simplify sensitive startup logging - #2407

Merged
ejsmith merged 3 commits into
mainfrom
issue/fix-sensitive-oauth-logging
Jul 28, 2026
Merged

Simplify sensitive startup logging#2407
ejsmith merged 3 commits into
mainfrom
issue/fix-sensitive-oauth-logging

Conversation

@ejsmith

@ejsmith ejsmith commented Jul 27, 2026

Copy link
Copy Markdown
Member

Summary

  • Automatically destructure ordinary configuration properties instead of maintaining duplicated property allowlists and capacity counts.
  • Maintain a compact rules table containing only properties whose values must be redacted or sanitized.
  • Preserve the existing connection-string and URI sanitization behavior.

Why

The main build failed after PR #2405 merged because the safe OAuth logging transformer manually duplicated every OAuthServerOptions property and did not include RefreshTokenReuseGracePeriod, added by PR #2404.

This change fixes the failure without requiring every ordinary option property to be copied into the logging implementation. New non-sensitive properties are logged automatically; new sensitive properties only need a redaction or sanitization rule.

Failed workflow: https://github.com/exceptionless/Exceptionless/actions/runs/30300072521

Verification

  • dotnet build --no-restore --configuration Debug (0 warnings, 0 errors)
  • dotnet test --no-build -- --filter-class Exceptionless.Tests.Logging.SensitiveDataLoggingTests (5 passed)
  • git diff --check

Breaking changes

None.

@ejsmith
ejsmith marked this pull request as ready for review July 27, 2026 21:30
@ejsmith ejsmith changed the title Fix OAuth startup logging property coverage Simplify sensitive startup logging Jul 27, 2026
@github-actions

Copy link
Copy Markdown

Code Coverage

Package Line Rate Branch Rate Complexity Health
Exceptionless.Core 73% 66% 9587
Exceptionless.AppHost 38% 40% 139
Exceptionless.Insulation 37% 35% 286
Exceptionless.Web 84% 67% 6935
Summary 77% (22857 / 29790) 66% (10501 / 16026) 16947

@ejsmith
ejsmith merged commit 903acc2 into main Jul 28, 2026
12 checks passed
@ejsmith
ejsmith deleted the issue/fix-sensitive-oauth-logging branch July 28, 2026 02:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant