Fix long tag overflow popover interactions - #2436
Conversation
|
@codex review |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33eb68057c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| fi | ||
|
|
||
| if command -v aspire >/dev/null 2>&1; then | ||
| exec aspire run --apphost src/Exceptionless.AppHost --no-build --nologo |
There was a problem hiding this comment.
When the Aspire CLI is on PATH (for example, the devcontainer installs it), this branch overrides the repo's aspire.config.json and passes the AppHost directory to --apphost. The Aspire run docs describe --apphost as taking an AppHost file/project file such as a .csproj (https://aspire.dev/reference/cli/commands/aspire-run/#options), and CLI versions that follow that contract fail on directories with “The specified project file does not exist”; use src/Exceptionless.AppHost/Exceptionless.AppHost.csproj or omit --apphost so the Run Aspire action works in CLI-equipped environments.
Useful? React with 👍 / 👎.
|
2 participants
Summary
+Noverflow summaries.Root cause
Hidden tags were rendered through the normal tooltip path inside the
+Ntooltip. Moving from the overflow trigger to a hidden tag opened or closed nested tooltip state, so the full hidden value was not reliably viewable or actionable. The overflow path now renders bounded, wrapping values directly and reuses the existing click handler.The visible badge is an
inline-flexcontainer. Truncation is applied and measured on its inner text span so padding and flex layout do not distort the overflow check.The first Aspire wrapper was not an Aspire crash: its historical log reached a healthy dashboard and running Api/App/Elasticsearch/Jobs before receiving a normal termination signal. The current desktop failure was separate: multiline TOML commands were pasted into an interactive zsh terminal, leaving the shell at
then>before Aspire could run. The Run actions now point to executable project-local scripts. The Aspire script resolves the worktree without requiringCODEX_WORKTREE_PATH, builds the AppHost from the repository root, starts Aspire with--no-build, and usesexecso logs and Ctrl-C remain attached.Verification
npm run validate— formatting, Svelte check, Prettier, and ESLint passed; 0 Svelte errors or warningsnpm run build-storybook— completed successfullyCODEX_WORKTREE_PATHabsent — stayed attached; Storybook and the long-tag story URL both returned HTTP 200CODEX_WORKTREE_PATHabsent — AppHost build succeeded, dashboard stayed attached, Api/App/Jobs and infrastructure reported healthy, API and Svelte app returned HTTP 200, and Ctrl-C stopped cleanlybash -n;git diff --checkpassedScope
This pull request contains the TagList component, stories, focused tests, and the narrowly scoped environment action repair. It does not include the earlier custom background process manager or a redundant
Run Siteaction;Run Aspirestarts the full local site. Local screenshots and dogfood reports remain ignored and are not part of the pull request.Before / after
The before/after screenshots are embedded here as GitHub user attachments; they are not repository files.