fix(ci): declare terser webpack plugin dependency#76
Merged
Conversation
This was referenced Jul 12, 2026
Contributor
Preview this PR in the Nextcloud PlaygroundA fresh Nextcloud boots in your browser with this branch's eXeLearning editor: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add
terser-webpack-pluginas an explicit development dependency and refreshpackage-lock.json.Root cause
PR #73 upgraded webpack from 5.107.2 to 5.108.4. Webpack 5.108.x replaced its internal
terser-webpack-plugindependency withminimizer-webpack-plugin, but@nextcloud/webpack-vue-config@7.0.2still importsterser-webpack-plugindirectly from its shared configuration.The package was therefore available only accidentally through webpack before #73. After the upgrade, every Nextcloud matrix job failed at
npm run buildwith:The standalone frontend job did not catch this because it runs linting, type checking, and Vitest, but not
npm run build.Fix
Declare
terser-webpack-plugindirectly in this application'sdevDependencies. This makes the dependency relationship explicit and keeps the unrelated Biome, Node types, and webpack updates from #73.Validation
npm civue-tsc --noEmitnpm run buildwith webpack 5.108.4The focused build verification completed successfully before the generated dependency files were committed.
Refs #73
Supersedes #74 and diagnostic PR #75.