Skip to content

fix(ci): declare terser webpack plugin dependency#76

Merged
erseco merged 1 commit into
mainfrom
hotfix/declare-terser-webpack-plugin
Jul 12, 2026
Merged

fix(ci): declare terser webpack plugin dependency#76
erseco merged 1 commit into
mainfrom
hotfix/declare-terser-webpack-plugin

Conversation

@erseco

@erseco erseco commented Jul 12, 2026

Copy link
Copy Markdown
Contributor

Summary

Add terser-webpack-plugin as an explicit development dependency and refresh package-lock.json.

Root cause

PR #73 upgraded webpack from 5.107.2 to 5.108.4. Webpack 5.108.x replaced its internal terser-webpack-plugin dependency with minimizer-webpack-plugin, but @nextcloud/webpack-vue-config@7.0.2 still imports terser-webpack-plugin directly from its shared configuration.

The package was therefore available only accidentally through webpack before #73. After the upgrade, every Nextcloud matrix job failed at npm run build with:

Error: Cannot find module 'terser-webpack-plugin'
Require stack:
- node_modules/@nextcloud/webpack-vue-config/webpack.config.js

The standalone frontend job did not catch this because it runs linting, type checking, and Vitest, but not npm run build.

Fix

Declare terser-webpack-plugin directly in this application's devDependencies. This makes the dependency relationship explicit and keeps the unrelated Biome, Node types, and webpack updates from #73.

Validation

  • npm ci
  • Biome
  • ESLint
  • vue-tsc --noEmit
  • Vitest
  • npm run build with webpack 5.108.4
  • Full Nextcloud/PHP CI matrix on this PR

The focused build verification completed successfully before the generated dependency files were committed.

Refs #73
Supersedes #74 and diagnostic PR #75.

@github-actions

Copy link
Copy Markdown
Contributor

Preview this PR in the Nextcloud Playground

Open this PR in the Nextcloud Playground

A fresh Nextcloud boots in your browser with this branch's exelearning app installed and enabled (log in as admin / admin). Two sample .elpx are seeded under exelearning-samples/ in Files — click one to open the viewer.

eXeLearning editor: v4.0.2 (overlaid at boot from the upstream release).

@erseco
erseco merged commit 813b80d into main Jul 12, 2026
14 checks passed
@erseco
erseco deleted the hotfix/declare-terser-webpack-plugin branch July 12, 2026 09:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant