Clean up default workspace directory#574
Merged
kytrinyx merged 3 commits intonextercismfrom Jun 22, 2018
Merged
Conversation
added 3 commits
June 22, 2018 16:49
Don't try to create the workspace directory on top of the binary, if the binary happens to be downloaded to the default workspace directory.
The default config had an empty string as Home, this writes Home first, so that the workspace goes there instead of in the current directory.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While testing the alpha-8 build we came across three issues with the default workspace directory:
.exesuffixcfg.Homewas emptyThis is still a hacky solution just to unlock some beta testing, I will do proper testing and cleanup when solving the workspace issues properly as described in #542
Merging as soon as the tests go green.
/cc @nywilken