Bump GHA Ubuntu workflow runners to Ubuntu 26.04#1026
Conversation
IsaacG
force-pushed
the
gha.ubuntu26
branch
2 times, most recently
from
9c08660 to
c5027c8
Compare
ahans
left a comment
ahans
left a comment
There was a problem hiding this comment.
Thanks for the push here. If reverting only the linux-min change does not work on its own and you don't want to look into Catch2 upgrading etc., I (or some other cpp maintainer) can take care of it.
| linux-min: | ||
| name: Linux Min Config | ||
| runs-on: ubuntu-22.04 | ||
| runs-on: ubuntu-26.04 |
There was a problem hiding this comment.
The idea here is to keep this at the latest version we officially support. Typically we increase that once official support ends. So ubuntu-22.04 here should stay until ~April 2027.
| with: | ||
| python-version: "3.10" | ||
| python-version: "3.14" |
There was a problem hiding this comment.
It should actually be save to throw that out and just use the default.
|
|
||
| namespace literals { | ||
| Approx operator "" _a(long double val) { | ||
| Approx operator ""_a(long double val) { |
There was a problem hiding this comment.
I believe we have this exact same file copied to each exercise. I'm not sure if changing only one is a good idea. If this fails on a newer compiler, we should probably upgrade Catch2 altogether (I feel we've discussed this and there was some reason not to upgrade, but I can't quite remember ...).
There was a problem hiding this comment.
Happy to mass-apply this change across the repo.
There was a problem hiding this comment.
There was a problem hiding this comment.
Still puzzled why it shows only in the complex-numbers test ...
There was a problem hiding this comment.
Hrm. That is odd. After #1027 is applied, it should no longer be there.
There was a problem hiding this comment.
All good, both are merged now and tests still pass. I was just wondering why you needed only the fix for complex-numbers. But TBH I didn't do much digging to find out. It's definitely good to fix it for all exercises, since that also affected students on newer compilers working locally. It already showed in CI for the macos test, where we have -latest.
|
@ahans Friendly ping :) |
|
|
||
| namespace literals { | ||
| Approx operator "" _a(long double val) { | ||
| Approx operator ""_a(long double val) { |
There was a problem hiding this comment.
Still puzzled why it shows only in the complex-numbers test ...
2 participants
No description provided.