Skip to content

update/complete haskell tags #1124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 17, 2022
Merged

update/complete haskell tags #1124

merged 2 commits into from
Nov 17, 2022

Conversation

@andreacfromtheapp
Copy link
Contributor

@andreacfromtheapp andreacfromtheapp commented Nov 12, 2022 •
edited
Loading

@MatthijsBlom
Copy link
Contributor

MatthijsBlom commented Nov 13, 2022 •
edited
Loading

@gacallea Presently paradigm/declarative is marked as justified but not present in the tag list. Do you disagree with the justification, or is it just an oversight?

Other than that, do you have anything to add? If not, I'll approve.

@andreacfromtheapp
Copy link
Contributor Author

andreacfromtheapp commented Nov 13, 2022

@gacallea Presently paradigm/declarative is marked as justified but not present in the tag list. Do you disagree with the justification, or is it just an oversight?

Other than that, do you have anything to add? If not, I'll approve.

Hi Matt, tbh I'm not sure. The reason I didn't put it is because Tags.md said "implicit with functional" so I thought it was going to be automatic. Bottom line: IF all other FP langs do have it, I'm going to add it here as well. Let me know :)

@andreacfromtheapp
Copy link
Contributor Author

andreacfromtheapp commented Nov 13, 2022

@MatthijsBlom better still: official wiki doesn't define it as declarative. I'd leave it out.

https://wiki.haskell.org/Introduction

@andreacfromtheapp
Copy link
Contributor Author

andreacfromtheapp commented Nov 13, 2022

pps: (sorry for the spam). Declarative suits languages as Prolog but not Haskell or similar FP. It is nitpicking but I'd not add declarative to FP langs that aren't "marked as such" from official resources.

@MatthijsBlom
Copy link
Contributor

MatthijsBlom commented Nov 13, 2022 •
edited
Loading

Going by Wikipedia (e.g. «Functional programming», «Declarative programming»), declarative languages form a superset of both functional languages and logical languages.

The section «What is functional programming» explicitly says that functional programming emphasizes the what over the how.

By the way: as is the nature of wikis, the wikis themselves might be 'official', but their contents generally aren't.

@andreacfromtheapp
Copy link
Contributor Author

andreacfromtheapp commented Nov 13, 2022

no problem then. If wikipedia is the primary source, then I'm ok with it. I usually prefer official sources if available. modifying the file :)

@MatthijsBlom
Copy link
Contributor

MatthijsBlom commented Nov 13, 2022

It seems I'm not allowed to Approve.

@petertseng I think this is mergeable.

@andreacfromtheapp andreacfromtheapp mentioned this pull request Nov 13, 2022
Merged
ErikSchierboom
ErikSchierboom approved these changes Nov 14, 2022
View reviewed changes
Copy link
Member

@ErikSchierboom ErikSchierboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like how you've documented the choices made.

ceddlyburge added a commit to exercism/elm that referenced this pull request Nov 15, 2022
@andreacfromtheapp @ceddlyburge
adding declarative to Elm Tags.md (see comment link) (#528)
9285458 
* adding declarative

as mentioned here, functional languages should be tagged declarative too. exercism/haskell#1124 (comment)

* adding TAGS.md

based on both haskell tags and javascript tags. didn't add checkmarks where not strictly official. however, commented those with "possible" where a technology can offer that functionality.

* Update TAGS.md

Co-authored-by: Cedd Burge <ceddlyburge@users.noreply.github.com>

Co-authored-by: Cedd Burge <ceddlyburge@users.noreply.github.com>
@andreacfromtheapp
Copy link
Contributor Author

andreacfromtheapp commented Nov 16, 2022

hi :)

I was wondering if there are any stoppers for this merge? Anything I should do?

please and thank you

@ErikSchierboom
Copy link
Member

ErikSchierboom commented Nov 16, 2022

@gacallea I'd like @petertseng to also look at this, as he's the resident Haskell maintainer.

@andreacfromtheapp
Copy link
Contributor Author

andreacfromtheapp commented Nov 16, 2022

@gacallea I'd like @petertseng to also look at this, as he's the resident Haskell maintainer.

@ErikSchierboom ok thank you :) i appreciate.

@ErikSchierboom
Copy link
Member

ErikSchierboom commented Nov 16, 2022

@gacallea If Peter hasn't found time to review in a couple of days, let me know and I'll merge.

@petertseng petertseng merged commit d5b26cf into exercism:main Nov 17, 2022
@andreacfromtheapp
Copy link
Contributor Author

andreacfromtheapp commented Nov 17, 2022

yay! thank you all :)

@andreacfromtheapp andreacfromtheapp mentioned this pull request Nov 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErikSchierboom ErikSchierboom ErikSchierboom approved these changes

@kytrinyx kytrinyx kytrinyx approved these changes

@petertseng petertseng Awaiting requested review from petertseng

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Missing Haskell characteristics when filtering Tracks. [v3] Add tags

5 participants

@andreacfromtheapp @MatthijsBlom @ErikSchierboom @kytrinyx @petertseng