Skip to content

Conversation

@exercism-bot
Copy link
Contributor

ℹ More info: exercism/org-wide-files@ceface8
👁 Tracking issue: exercism/org-wide-files#273

@exercism-bot exercism-bot requested a review from a team as a code owner November 17, 2022 13:32
Copy link
Member

@ee7 ee7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@petertseng
Copy link
Member

that's a lot of changes! too many to put in one commit. Please use #1126 instead, and do not squash those commits

@petertseng petertseng closed this Nov 17, 2022
@petertseng
Copy link
Member

petertseng commented Nov 17, 2022

I understand that I've created extra unnecessary work for the exercism/maintainers-admin by opening a new pull request (because now maintainers-admin must approve that pull request, instead of this one which they've already approved), but I was required to do so because exercism-bot didn't allow edits to the pull request. I apologise very much for the inconvenience. I was required to do this because of the guidelines in https://github.com/exercism/legacy-docs/blob/main/contributing/git-basics.md#commit-messages

To avoid this extra work in the future, might I suggest the exercism-bot allow edits to its pull requests?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants