Skip to content

Conversation

@DWalz
Copy link
Contributor

@DWalz DWalz commented Jun 7, 2023

Create Exercis Stubs as mentioned in #2133

Add Exercise Stubs for all exercises mentioned in this comment except for allergies (#2303) and pig-latin (#2315) which are still pending.

I have used final for every function parameter. Function parameters are not final
All classes are package-private.

DWalz added 30 commits June 7, 2023 20:51
@SleeplessByte
Copy link
Member

@DWalz 3 exercises are failing. Knapsack, Hangman, and Rest-Api.

Can you check if this is "you" or something else? If it's something else we can merge this and fix it separately.

Projects that add external dependencies using the `implementation` dependency configuration in their build.gradle file didn't get those dependencies installed when building the 'starterSource' source sets in CI.
@sanderploegsma
Copy link
Contributor

@DWalz 3 exercises are failing. Knapsack, Hangman, and Rest-Api.

Can you check if this is "you" or something else? If it's something else we can merge this and fix it separately.

I looked into the failures and two of them were caused by a Gradle configuration issue that had nothing to do with the individual exercise configs. I pushed a fix for that, because it's just made visible by the changes in this PR even though this issue was already present in main.

The Knapsack exercise still doesn't compile because it references a class Item that is not present in the stub. @DWalz if you could address this we can get this merged.

@DWalz
Copy link
Contributor Author

DWalz commented Aug 26, 2023

The Item class was indeed missing. I added it with the same implementation from the solution. I assume this class doesn't have to be implemented by the solver themselves.

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I found two more small things to take care of though.

@DWalz
Copy link
Contributor Author

DWalz commented Aug 26, 2023

Done. I even remember reading through that in the contributor guide... 😅

Copy link
Contributor

@sanderploegsma sanderploegsma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! @SleeplessByte do you want to have a final look?

@sanderploegsma
Copy link
Contributor

I’m guessing that’s a no 😉

@sanderploegsma sanderploegsma added the x:size/medium Medium amount of work label Aug 29, 2023
@sanderploegsma sanderploegsma merged commit 37f47a7 into exercism:main Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

x:size/medium Medium amount of work

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants