-
-
Notifications
You must be signed in to change notification settings - Fork 737
Exercise stubs for missing exercises #2319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Maybe we want to change the return type of the move functions to allow for method chaining like the solution suggests - it is not strictly necessary to sucessfully run the tests
|
@DWalz 3 exercises are failing. Knapsack, Hangman, and Rest-Api. Can you check if this is "you" or something else? If it's something else we can merge this and fix it separately. |
Projects that add external dependencies using the `implementation` dependency configuration in their build.gradle file didn't get those dependencies installed when building the 'starterSource' source sets in CI.
I looked into the failures and two of them were caused by a Gradle configuration issue that had nothing to do with the individual exercise configs. I pushed a fix for that, because it's just made visible by the changes in this PR even though this issue was already present in The Knapsack exercise still doesn't compile because it references a class |
|
The |
sanderploegsma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! I found two more small things to take care of though.
|
Done. I even remember reading through that in the contributor guide... 😅 |
sanderploegsma
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! @SleeplessByte do you want to have a final look?
|
I’m guessing that’s a no 😉 |
Create Exercis Stubs as mentioned in #2133
Add Exercise Stubs for all exercises mentioned in this comment except for
allergies(#2303) andpig-latin(#2315) which are still pending.I have usedFunction parameters are notfinalfor every function parameter.finalAll classes are
package-private.