#2133: Added UnsupportedOperationException PigLatinTranslator #2315
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sanderploegsma
requested changes
Aug 25, 2023
Contributor
sanderploegsma
left a comment
sanderploegsma
left a comment
There was a problem hiding this comment.
Thanks for your contribution! If you could address these comments I'd be happy to approve your PR.
Comment on lines
+25
to
+28
|
|
||
| tasks.named("compileTestJava").configure { | ||
| dependsOn("copyTestsFilteringIgnores") | ||
| } |
Contributor
There was a problem hiding this comment.
This change should no longer be needed, as the Gradle configuration was fixed in #2339
Contributor
There was a problem hiding this comment.
Could you fix the formatting of this stub?
- Make sure the import section and the class definition is separated by a new line
- Make sure the file ends with a final new line
| Please remove this comment when submitting your solution. | ||
| */ | ||
| public String translate(String text) { |
Contributor
There was a problem hiding this comment.
I would prefer the method parameter to be named sentence like in the example implementation. It gives the student a small hint in terms of what to expect in terms of input.
Contributor
|
Oh in fact, I just noticed this PR is now obsolete, as it was already added in #2326, sorry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a constructor and a
translate()method that raiseUnsupportedOperationExceptions, as mentioned in issue #2133.Also added code to remove gradle warning as specified with this Stack Overflow post.
Reviewer Resources:
Track Policies