-
-
Notifications
You must be signed in to change notification settings - Fork 738
Fix CI silently not running exercise tests #2339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1143505 to
df8f1e9
Compare
This is not the best solution, probably it would be better if the CI script is able to parse the config.json file and copy all files listed in `files.editor` and `files.exemplar`, but for now duplicating the editor files into the exemplar implementation should help to unblock the CI build.
By making `test` depend on `copyTestsFilteringIgnores`, Gradle would run `compileTestJava` -> `copyTestFilteringIgnores` -> `Test`. This fails because there is nothing to compile in the test sourceset, since it has not been generated yet. The correct task order should be `copyTestsFilteringIgnores` -> `compileTestJava` -> `Test`.
df8f1e9 to
0428579
Compare
Member
|
@sanderploegsma Could you look into the CI failure please? |
Contributor
Author
|
@ErikSchierboom all done, they should pass now: https://github.com/sanderploegsma/exercism-track-java/actions/runs/5962186142 |
ErikSchierboom
approved these changes
Aug 24, 2023
Member
ErikSchierboom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was investigating why the bug in #2330 didn't cause a failure in CI, and apparently the exercises aren't tested at all due to an error in the test script!
It appears there are multiple things wrong with this script:
bin/journey-test.shscript wasn't updated to parseconfig.jsoncorrectly after the addition of concept exercises, so none of the tests even ranAfter some fiddling with the script I noticed that the
exercises/build.gradlescript is configured to do exactly what is required in CI: it pre-processes the test files to remove any@Ignoretags and then runs the tests against the exemplar/example implementation. So I figured the easiest way to fix the CI pipeline is to just rungradle test.Note that because the CI pipeline has probably been broken for a while, there were a few exercises of which the example implementation doesn't pass their own test cases. I fixed the easy ones, but the following practice exercises seem to require a bit more attention to get their tests passing:
Reviewer Resources:
Track Policies