Skip to content

Conversation

@IsaacG
Copy link
Member

@IsaacG IsaacG commented Jan 26, 2024

The base repo LICENSE should suffice.

git will honor the root .gitignore if a child directory does not contain one.

The base repo LICENSE should suffice.

git will honor the root .gitignore if a child directory does not contain one.
@SleeplessByte
Copy link
Member

Both need to be copied because the exercises are downloaded individually. There is no "root" file when setting up a track via the Exercism CLI.

@IsaacG
Copy link
Member Author

IsaacG commented Jan 31, 2024

Is there a reason this track needs to download the license with every exercise? Should this happen on all tracks? Most tracks do not do this.

@IsaacG IsaacG reopened this Feb 1, 2024
@SleeplessByte
Copy link
Member

We have seen JavaScript students directly upload their solutions to their github or gitlab. Stripping the license is probably not something we want ;)

@IsaacG
Copy link
Member Author

IsaacG commented Feb 1, 2024

How does that differ from other tracks?

@SleeplessByte
Copy link
Member

I don't know why what other tracks have done should impact how JavaScript is set up. For example for the longest time JavaScript was the only track that formatted the config.json to be sorted on difficulty and then lexicographically. We also include the .gitignore because people don't know how git works, but technically it doesn't need to be there, again because it helps reducing support requests of people uploading MBs/GBs to repositories.

As long as there is no top-down guidance on these things, I don't think tracks need to be uniform here.

@IsaacG
Copy link
Member Author

IsaacG commented Feb 1, 2024

If it makes sense that each exercise download should include a license to protect Exercism's intellectual property, then that should always be true. If there is no need for each download to include a license to protect their IP, then there is no need for one.

Some aspects of track tooling make sense to change from track to track based on language needs and tooling. Other aspects, like whether or not a license file should always be present, are not related to the language or tooling in any way. Things not related to the language or tooling should be uniform where possible and handled at an org level.

Is there any reason the license thing should be different in this track vs others? If not, it should be consistent and handled at the org level.

+cc @iHiD and @ErikSchierboom for licensing input.

@SleeplessByte
Copy link
Member

This is not the place to discuss this, perhaps somewhere on the forum would be better?

That said, I am in agreement that we probably want some unification across tracks here and in my opinion all tracks should always include a LICENSE file for all downloads. However, perhaps both our energies are better spent fixing the CI things on this track than making this change right now?

@ErikSchierboom
Copy link
Member

A forum post would be great.

@kotp
Copy link
Member

kotp commented Feb 23, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants