-
-
Notifications
You must be signed in to change notification settings - Fork 655
Stop making copies of LICENSE and .gitignore files for each exercise. #2374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The base repo LICENSE should suffice. git will honor the root .gitignore if a child directory does not contain one.
|
Both need to be copied because the exercises are downloaded individually. There is no "root" file when setting up a track via the Exercism CLI. |
|
Is there a reason this track needs to download the license with every exercise? Should this happen on all tracks? Most tracks do not do this. |
|
We have seen JavaScript students directly upload their solutions to their github or gitlab. Stripping the license is probably not something we want ;) |
|
How does that differ from other tracks? |
|
I don't know why what other tracks have done should impact how JavaScript is set up. For example for the longest time JavaScript was the only track that formatted the config.json to be sorted on difficulty and then lexicographically. We also include the As long as there is no top-down guidance on these things, I don't think tracks need to be uniform here. |
|
If it makes sense that each Some aspects of track tooling make sense to change from track to track based on language needs and tooling. Other aspects, like whether or not a license file should always be present, are not related to the language or tooling in any way. Things not related to the language or tooling should be uniform where possible and handled at an org level. Is there any reason the license thing should be different in this track vs others? If not, it should be consistent and handled at the org level. +cc @iHiD and @ErikSchierboom for licensing input. |
|
This is not the place to discuss this, perhaps somewhere on the forum would be better? That said, I am in agreement that we probably want some unification across tracks here and in my opinion all tracks should always include a LICENSE file for all downloads. However, perhaps both our energies are better spent fixing the CI things on this track than making this change right now? |
|
A forum post would be great. |
The base repo LICENSE should suffice.
git will honor the root .gitignore if a child directory does not contain one.