Skip to content

Add more practice exercises - #23

Open
YanniPapandreou wants to merge 14 commits into
mainfrom
more-exercises
Open

Add more practice exercises#23
YanniPapandreou wants to merge 14 commits into
mainfrom
more-exercises

Conversation

@YanniPapandreou

Copy link
Copy Markdown

Helps with task 'Add initial exercises' in #1.

This PR adds implementations for 8 more exercises:

  1. nucleotide-count
  2. allergies
  3. leap
  4. raindrops
  5. protein-translation
  6. grains
  7. gigasecond
  8. meetup

With these there are now 23 practice exercises.

@quintuple-mallard quintuple-mallard left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall!

Comment thread .github/workflows/test.yml
Comment thread exercises/practice/gigasecond/.meta/tests.toml
Comment thread exercises/practice/gigasecond/tests.nu Outdated
YanniPapandreou and others added 2 commits July 28, 2026 22:19
Co-authored-by: J R M <jwrmmine@protonmail.com>
Co-authored-by: J R M <jwrmmine@protonmail.com>
@IsaacG

IsaacG commented Jul 28, 2026

Copy link
Copy Markdown
Member

It's good practice to keep PRs small and targeted. A PR that changes the version should only change the version. Each additional exercise probably merits its own PR.

@YanniPapandreou

Copy link
Copy Markdown
Author

It's good practice to keep PRs small and targeted. A PR that changes the version should only change the version. Each additional exercise probably merits its own PR.

I'm happy to close this and split this into several PRs - I just didn't want to create extra burden on @quintuple-mallard - and also wasn't sure who else is maintaining this track :) The commits are mostly atomic so wouldn't be too hard for me to go back and open several PRs

@IsaacG

IsaacG commented Jul 29, 2026

Copy link
Copy Markdown
Member

I'm happy to close this and split this into several PRs - I just didn't want to create extra burden on @quintuple-mallard - and also wasn't sure who else is maintaining this track :)

It's just the two of you maintaining this track for now.

Smaller PRs are also much easier to read and review!

@quintuple-mallard

Copy link
Copy Markdown
Member

It's good practice to keep PRs small and targeted. A PR that changes the version should only change the version. Each additional exercise probably merits its own PR.

I'm happy to close this and split this into several PRs - I just didn't want to create extra burden on @quintuple-mallard - and also wasn't sure who else is maintaining this track :) The commits are mostly atomic so wouldn't be too hard for me to go back and open several PRs

In general I would prefer if you opened several smaller PRs instead of on large one, but in this case, it doesn't really matter.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants