Skip to content

Use zip_longest for handling test data comparison #4022

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Use zip_longest for handling test data comparison #4022

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion exercises/concept/ellens-alien-game/classes_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
from functools import zip_longest
import unittest
import pytest

Expand Down Expand Up @@ -204,7 +205,7 @@ def test_new_aliens_collection(self):
for obj in actual_result:
self.assertIsInstance(obj, Alien, msg=error_message)

for position, obj in zip(test_data, actual_result):
for position, obj in zip_longest(test_data, actual_result):
position_error = (f'After calling new_aliens_collection({test_data}), '
f'found {obj} initialized to position {(obj.x_coordinate, obj.y_coordinate)}, '
f'but the tests expected {obj} to be at position {position} instead.')
Expand Down
Loading