RNA Transcription and Atbash Cipher approach cleanup#4191
Conversation
BethanyG
left a comment
BethanyG
left a comment
There was a problem hiding this comment.
I am being a pendant here, but I think it is really important to poke students about "character" vs "code point". We have to be careful, even with basic ASCII to not confuse the two - it becomes a deadly mental model the minute you get to anything with a diacritical mark or accent. Its even worse when you work with any multi-codepoint glyphs (like emoji or Kanji). It's a ...whole thing.
Otherwise, great work here. Thanks so much for cleaning this mess up.
Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
BethanyG
left a comment
BethanyG
left a comment
There was a problem hiding this comment.
Still a tad triggered by those last "character" refs but agree they are better as-is for clarity. (Or at least I hope that brings clarity).
|
Shall we let this one sit and re-read, or are you read for merge? 😄 |
|
You bet I am ready to merge! I am not letting that |
|
BTW, if another approach for any of these comes to you, please feel free to write one (or not!). |
2 participants
As discussed in this issue.