python matrix added. #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Nice! This seems like an excellent first pass. Once it meets reality then someone might have ideas for improvement. Thank you ❤️ |
ErikSchierboom
referenced
this pull request
in ErikSchierboom/python
Jan 21, 2021
* First * Add : config.json authors & editor * Add : exchange file exchange_test / exchange * Fix : typo Line 2 from .exchange import * -> from exchange import * * Fix : Forder Name * Fix : Folder Name * Added example and instructions. (#6) added : currency-exchange/.meta/example.py added : currency-exchange/.docs/instructions.md * Added design.md (#7) * added design.md added : currency-exchange/.meta/design.md * Added hint.md (#8) Added hint.md (#8) * Add : hint.md (#10) * Delete .DS_Store * Add : hint.md (#9) Add : hint.md Solving Conflict * Add introduction.md (#8) * Fix: typo (#11) fix exchangable to exchangeable fix "Chandler want" to "Chandler wants" in instructions.md * Change File_name & Prettier (#12) * Fix : Prettier (#13) * Add : slug to config.json (#14) * Fix config (#15) * Fix introduction.md (#16) * Fix instructions.md (#17) * Fixed instructions.md Fixed grammatical errors in instructions.md based on BethanyG's review. Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com> * add testcase * Added problem "6. Calculate unexchangeable value" (#19) * Added new problem "Calculate unexchangeable value" Added modular arithmetic problem Calculate unexchangeable value * Added new problem "Calculate unexchangeable value" (example.py, exchange.py) Modified example.py, exchange.py * Modified Calculated unexchangeable value Modified `unexchangeable_value()` function's expected return type to be `int` * added new lines at the end of file * applied prettier on instructions.md Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com> * Add : Problem Design (#20) * Update languages/config.json we changed the concept name, so needed to update file. * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.meta/config.json we've decided to name the stub and test files for the concept and not the story. * Update languages/exercises/concept/currency-exchange/.meta/design.md minor typo * Update languages/exercises/concept/currency-exchange/exchange_test.py * Update languages/exercises/concept/currency-exchange/exchange_test.py * Update languages/exercises/concept/currency-exchange/.docs/introduction.md Co-authored-by: Yunseon Choi <science_co@naver.com> * Update languages/config.json removed arithmetic as a concept until we get the about.md file made. * Update languages/exercises/concept/currency-exchange/.meta/config.json reverting file name change and deferring to different PR. This is currently breaking a CI test. Co-authored-by: Yoggy <wjdek88@naver.com> Co-authored-by: Seunghun Yang <Yabby1997@gmail.com> Co-authored-by: Ticktakto <50654571+Ticktakto@users.noreply.github.com> Co-authored-by: Yunseon Choi <science_co@naver.com> Co-authored-by: wnstj2007 <43427152+wnstj2007@users.noreply.github.com> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
ErikSchierboom
referenced
this pull request
in ErikSchierboom/python
Jan 22, 2021
* First * Add : config.json authors & editor * Add : exchange file exchange_test / exchange * Fix : typo Line 2 from .exchange import * -> from exchange import * * Fix : Forder Name * Fix : Folder Name * Added example and instructions. (#6) added : currency-exchange/.meta/example.py added : currency-exchange/.docs/instructions.md * Added design.md (#7) * added design.md added : currency-exchange/.meta/design.md * Added hint.md (#8) Added hint.md (#8) * Add : hint.md (#10) * Delete .DS_Store * Add : hint.md (#9) Add : hint.md Solving Conflict * Add introduction.md (#8) * Fix: typo (#11) fix exchangable to exchangeable fix "Chandler want" to "Chandler wants" in instructions.md * Change File_name & Prettier (#12) * Fix : Prettier (#13) * Add : slug to config.json (#14) * Fix config (#15) * Fix introduction.md (#16) * Fix instructions.md (#17) * Fixed instructions.md Fixed grammatical errors in instructions.md based on BethanyG's review. Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com> * add testcase * Added problem "6. Calculate unexchangeable value" (#19) * Added new problem "Calculate unexchangeable value" Added modular arithmetic problem Calculate unexchangeable value * Added new problem "Calculate unexchangeable value" (example.py, exchange.py) Modified example.py, exchange.py * Modified Calculated unexchangeable value Modified `unexchangeable_value()` function's expected return type to be `int` * added new lines at the end of file * applied prettier on instructions.md Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com> * Add : Problem Design (#20) * Update languages/config.json we changed the concept name, so needed to update file. * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.meta/config.json we've decided to name the stub and test files for the concept and not the story. * Update languages/exercises/concept/currency-exchange/.meta/design.md minor typo * Update languages/exercises/concept/currency-exchange/exchange_test.py * Update languages/exercises/concept/currency-exchange/exchange_test.py * Update languages/exercises/concept/currency-exchange/.docs/introduction.md Co-authored-by: Yunseon Choi <science_co@naver.com> * Update languages/config.json removed arithmetic as a concept until we get the about.md file made. * Update languages/exercises/concept/currency-exchange/.meta/config.json reverting file name change and deferring to different PR. This is currently breaking a CI test. Co-authored-by: Yoggy <wjdek88@naver.com> Co-authored-by: Seunghun Yang <Yabby1997@gmail.com> Co-authored-by: Ticktakto <50654571+Ticktakto@users.noreply.github.com> Co-authored-by: Yunseon Choi <science_co@naver.com> Co-authored-by: wnstj2007 <43427152+wnstj2007@users.noreply.github.com> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
ErikSchierboom
referenced
this pull request
in ErikSchierboom/python
Jan 26, 2021
* First * Add : config.json authors & editor * Add : exchange file exchange_test / exchange * Fix : typo Line 2 from .exchange import * -> from exchange import * * Fix : Forder Name * Fix : Folder Name * Added example and instructions. (#6) added : currency-exchange/.meta/example.py added : currency-exchange/.docs/instructions.md * Added design.md (#7) * added design.md added : currency-exchange/.meta/design.md * Added hint.md (#8) Added hint.md (#8) * Add : hint.md (#10) * Delete .DS_Store * Add : hint.md (#9) Add : hint.md Solving Conflict * Add introduction.md (#8) * Fix: typo (#11) fix exchangable to exchangeable fix "Chandler want" to "Chandler wants" in instructions.md * Change File_name & Prettier (#12) * Fix : Prettier (#13) * Add : slug to config.json (#14) * Fix config (#15) * Fix introduction.md (#16) * Fix instructions.md (#17) * Fixed instructions.md Fixed grammatical errors in instructions.md based on BethanyG's review. Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com> * add testcase * Added problem "6. Calculate unexchangeable value" (#19) * Added new problem "Calculate unexchangeable value" Added modular arithmetic problem Calculate unexchangeable value * Added new problem "Calculate unexchangeable value" (example.py, exchange.py) Modified example.py, exchange.py * Modified Calculated unexchangeable value Modified `unexchangeable_value()` function's expected return type to be `int` * added new lines at the end of file * applied prettier on instructions.md Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com> * Add : Problem Design (#20) * Update languages/config.json we changed the concept name, so needed to update file. * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.meta/config.json we've decided to name the stub and test files for the concept and not the story. * Update languages/exercises/concept/currency-exchange/.meta/design.md minor typo * Update languages/exercises/concept/currency-exchange/exchange_test.py * Update languages/exercises/concept/currency-exchange/exchange_test.py * Update languages/exercises/concept/currency-exchange/.docs/introduction.md Co-authored-by: Yunseon Choi <science_co@naver.com> * Update languages/config.json removed arithmetic as a concept until we get the about.md file made. * Update languages/exercises/concept/currency-exchange/.meta/config.json reverting file name change and deferring to different PR. This is currently breaking a CI test. Co-authored-by: Yoggy <wjdek88@naver.com> Co-authored-by: Seunghun Yang <Yabby1997@gmail.com> Co-authored-by: Ticktakto <50654571+Ticktakto@users.noreply.github.com> Co-authored-by: Yunseon Choi <science_co@naver.com> Co-authored-by: wnstj2007 <43427152+wnstj2007@users.noreply.github.com> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
ErikSchierboom
referenced
this pull request
in ErikSchierboom/python
Jan 27, 2021
* First * Add : config.json authors & editor * Add : exchange file exchange_test / exchange * Fix : typo Line 2 from .exchange import * -> from exchange import * * Fix : Forder Name * Fix : Folder Name * Added example and instructions. (#6) added : currency-exchange/.meta/example.py added : currency-exchange/.docs/instructions.md * Added design.md (#7) * added design.md added : currency-exchange/.meta/design.md * Added hint.md (#8) Added hint.md (#8) * Add : hint.md (#10) * Delete .DS_Store * Add : hint.md (#9) Add : hint.md Solving Conflict * Add introduction.md (#8) * Fix: typo (#11) fix exchangable to exchangeable fix "Chandler want" to "Chandler wants" in instructions.md * Change File_name & Prettier (#12) * Fix : Prettier (#13) * Add : slug to config.json (#14) * Fix config (#15) * Fix introduction.md (#16) * Fix instructions.md (#17) * Fixed instructions.md Fixed grammatical errors in instructions.md based on BethanyG's review. Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com> * add testcase * Added problem "6. Calculate unexchangeable value" (#19) * Added new problem "Calculate unexchangeable value" Added modular arithmetic problem Calculate unexchangeable value * Added new problem "Calculate unexchangeable value" (example.py, exchange.py) Modified example.py, exchange.py * Modified Calculated unexchangeable value Modified `unexchangeable_value()` function's expected return type to be `int` * added new lines at the end of file * applied prettier on instructions.md Co-authored-by: Limm-jk <201602057@cs-cnu.org> Co-authored-by: Junkyu Lim <57378834+Limm-jk@users.noreply.github.com> * Add : Problem Design (#20) * Update languages/config.json we changed the concept name, so needed to update file. * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.docs/introduction.md * Update languages/exercises/concept/currency-exchange/.meta/config.json we've decided to name the stub and test files for the concept and not the story. * Update languages/exercises/concept/currency-exchange/.meta/design.md minor typo * Update languages/exercises/concept/currency-exchange/exchange_test.py * Update languages/exercises/concept/currency-exchange/exchange_test.py * Update languages/exercises/concept/currency-exchange/.docs/introduction.md Co-authored-by: Yunseon Choi <science_co@naver.com> * Update languages/config.json removed arithmetic as a concept until we get the about.md file made. * Update languages/exercises/concept/currency-exchange/.meta/config.json reverting file name change and deferring to different PR. This is currently breaking a CI test. Co-authored-by: Yoggy <wjdek88@naver.com> Co-authored-by: Seunghun Yang <Yabby1997@gmail.com> Co-authored-by: Ticktakto <50654571+Ticktakto@users.noreply.github.com> Co-authored-by: Yunseon Choi <science_co@naver.com> Co-authored-by: wnstj2007 <43427152+wnstj2007@users.noreply.github.com> Co-authored-by: BethanyG <BethanyG@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And another exercise…
Please tell me if you think something should be improved here!