fix crash if submission contains doctest - #203
Merged
Merged
Conversation
Member
|
Just ping me once you get things sorted. If i approve now, you'll just have to ask again if you are making changes. 🙂 |
Member
I don't think approvals get reset on PR changes |
IsaacG
approved these changes
Jul 28, 2026
Contributor
Author
|
Not sure what fixed it, I left the code pretty much the same... I just swapped out the example, because I realized we do have an exercise that already contains doctests. I'm planning to add support to extract the test code from doctests (in a later PR). |
senekor
force-pushed
the
senekor/doctest
branch
15 times, most recently
from
July 29, 2026 11:22
aa1d081 to
63e978a
Compare
When a doctest is present, cargo emits an additional "report" event. We shouldn't crash when users submit doctest, so just parse and ignore it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #202