knapsack accept slices

[victor-prokhorov]

make the function accept both vectors and slices

[github-actions]

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

---

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

[senekor]

@ErikSchierboom this PR was discussed on the Forum.

[senekor]

LGTM 👍

[senekor]

@victor-prokhorov I think the example file needs to be updated as well.

[victor-prokhorov]

@remlse @dem4ron should i squash all of the commits into one?

[dem4ron]

@victor-prokhorov Yes, commits must be squashed, but I think it is enough to do it with the Squash and Merge button.

Also, could you please remove all the other vec! macros from the test file?
Thank you

[ErikSchierboom]

but I think it is enough to do it with the Squash and Merge button.

That is correct.

[dem4ron]

Great, thank you!

[dem4ron]

@victor-prokhorov one last thing: Could you add yourself as a contributor?

in knapsack/.meta/config.json create an array called "contributors" and add your github handle :)