Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions exercises/practice/knapsack/.meta/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,9 @@
"authors": [
"dem4ron"
],
"contributors": [
"victor-prokhorov"
],
"files": {
"solution": [
"src/lib.rs",
Expand Down
2 changes: 1 addition & 1 deletion exercises/practice/knapsack/.meta/example.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ pub struct Item {
pub value: u32,
}

pub fn maximum_value(max_weight: u32, items: Vec<Item>) -> u32 {
pub fn maximum_value(max_weight: u32, items: &[Item]) -> u32 {
let mut max_values = vec![vec![0; (max_weight + 1) as usize]; items.len() + 1];

for i in 1..=items.len() {
Expand Down
2 changes: 1 addition & 1 deletion exercises/practice/knapsack/src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,6 @@ pub struct Item {
pub value: u32,
}

pub fn maximum_value(_max_weight: u32, _items: Vec<Item>) -> u32 {
pub fn maximum_value(_max_weight: u32, _items: &[Item]) -> u32 {
unimplemented!("Solve the knapsack exercise");
}
28 changes: 14 additions & 14 deletions exercises/practice/knapsack/tests/knapsack.rs
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ use knapsack::*;
#[test]
fn test_example_knapsack() {
let max_weight = 10;
let items = vec![
let items = [
Item {
weight: 5,
value: 10,
Expand All @@ -22,35 +22,35 @@ fn test_example_knapsack() {
},
];

assert_eq!(maximum_value(max_weight, items), 90);
assert_eq!(maximum_value(max_weight, &items), 90);
}

#[test]
#[ignore]
fn test_no_items() {
let max_weight = 100;
let items = vec![];
let items = [];

assert_eq!(maximum_value(max_weight, items), 0);
assert_eq!(maximum_value(max_weight, &items), 0);
}

#[test]
#[ignore]
fn test_one_item_too_heavy() {
let max_weight = 10;
let items = vec![Item {
let items = [Item {
weight: 100,
value: 1,
}];

assert_eq!(maximum_value(max_weight, items), 0);
assert_eq!(maximum_value(max_weight, &items), 0);
}

#[test]
#[ignore]
fn test_five_items_cannot_be_greedy_by_weight() {
let max_weight = 10;
let items = vec![
let items = [
Item {
weight: 2,
value: 5,
Expand All @@ -73,14 +73,14 @@ fn test_five_items_cannot_be_greedy_by_weight() {
},
];

assert_eq!(maximum_value(max_weight, items), 21);
assert_eq!(maximum_value(max_weight, &items), 21);
}

#[test]
#[ignore]
fn test_five_items_cannot_be_greedy_by_value() {
let max_weight = 10;
let items = vec![
let items = [
Item {
weight: 2,
value: 20,
Expand All @@ -103,14 +103,14 @@ fn test_five_items_cannot_be_greedy_by_value() {
},
];

assert_eq!(maximum_value(max_weight, items), 80);
assert_eq!(maximum_value(max_weight, &items), 80);
}

#[test]
#[ignore]
fn test_8_items() {
let max_weight = 104;
let items = vec![
let items = [
Item {
weight: 25,
value: 350,
Expand Down Expand Up @@ -145,14 +145,14 @@ fn test_8_items() {
},
];

assert_eq!(maximum_value(max_weight, items), 900);
assert_eq!(maximum_value(max_weight, &items), 900);
}

#[test]
#[ignore]
fn test_15_items() {
let max_weight = 750;
let items = vec![
let items = [
Item {
weight: 70,
value: 135,
Expand Down Expand Up @@ -215,5 +215,5 @@ fn test_15_items() {
},
];

assert_eq!(maximum_value(max_weight, items), 1458);
assert_eq!(maximum_value(max_weight, &items), 1458);
}