bit checking order is reversed in tests #578
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I believe the tests for this exercise are written expecting we check the bits from right to left, not left to right as indicated here. `testShuffle1` and `testShuffle3` both pass regardless of which direction we go, but `testShuffle2` fails when going left to right.
If starting with leftmost is the correct behavior, then I believe `testShuffle2` should expect to get `("Purple", "Marigold", "Cyan")` instead of the `("Marigold", "Cyan", "Purple")` it currently wants (I could do a different PR with that change instead of this if that's the right thing).
I might also just be confused and it's correct as is!!
Member
|
Pinging @exercism/reviewers |
Contributor
Author
|
Ah! My mistake, I failed to check existing PRs before opening this one. Apologies for the noise. @paiv, would you like me to close this? |
Member
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I believe the tests for this exercise are written expecting we check the bits from right to left, not left to right as indicated here.
testShuffle1andtestShuffle3both pass regardless of which direction we go, buttestShuffle2fails when going left to right.If starting with leftmost is the correct behavior, then I believe
testShuffle2should expect to get("Purple", "Marigold", "Cyan")instead of the("Marigold", "Cyan", "Purple")it currently wants (I could do a different PR with that change instead of this if that's the right thing).I might also just be confused and it's correct as is!!