Add line-up
#362
Merged
Add line-up
#362
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BNAndras
added
x:module/practice-exercise
kotp
approved these changes
Oct 14, 2025
| elseif l:mod10 == 3 && l:mod100 != 13 | ||
| return 'rd' | ||
| endif | ||
| return 'th' |
There was a problem hiding this comment.
Consider continuing the if statement with an else as the default. The return 'th' is otherwise an implicit else and makes it seem like it is not related to the if statement.
This is an example solution, though, so does not need to be exemplar.
There was a problem hiding this comment.
Line 17 is the happy path for most numbers so it's aligned to the left while the if....elseifs are the special cases. Considering each branch returns, I could do away with the elseif and do if for the three special cases, but I didn't want to bother adding the additional endif lines.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.