Skip to content

Update bin/add-exercise#452

Merged
keiravillekode merged 1 commit intoexercism:mainfrom
keiravillekode:add-exercise
Jun 1, 2025
Merged

Update bin/add-exercise#452
keiravillekode merged 1 commit intoexercism:mainfrom
keiravillekode:add-exercise

Conversation

@keiravillekode
Copy link
Contributor

@keiravillekode keiravillekode commented May 29, 2025

Updated from generic-track

We extend the script to sort exercises by (difficulty, slug)

kotp
kotp previously requested changes May 29, 2025
Copy link
Member

@kotp kotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title and topic of this seems to be "Update bin/add-exercise" but it has more than only that.

The restructuring of the order of the exercises is a completely different topic.

These should be two different pull requests, right?

If this had only the adjustment of the difficulties, I would have approved it and we would be done with that. But because it is attached to this topic, it is going to be more convoluted.

It is a good thing that the commits are atomic, though, so this is easily remedied.

@keiravillekode
Copy link
Contributor Author

I added sorting to bin/add-exercise, so then I also sort config.json But then some problematic difficulty estimates become obvious (anagram should not be 1).

Now extracted the difficulty adjustment into #453

From there, the config.json in this PR can be recreated using

filter='.exercises.practice = (.exercises.practice | sort_by(.difficulty, .slug))'
jq "${filter}" config.json > config.sorted && mv config.sorted config.json

@kotp
Copy link
Member

kotp commented May 30, 2025

So this patch should likely only involve commit d461540 right?

@kotp kotp dismissed their stale review May 30, 2025 06:27

Effectively, the re-evaluation of difficulty is not here. However, the original description of this pull request should be updated to describe the PR as it currently is.

@keiravillekode keiravillekode merged commit 7580e89 into exercism:main Jun 1, 2025
7 checks passed
@keiravillekode keiravillekode deleted the add-exercise branch June 1, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants