Re-land BindingContext.PropertyType regression test on master - #10
Merged
Conversation
Guards the B4 fix (PR #8): BindingContext.PropertyType must expose each property's own type, not its declaring interface. Verified fail-first — with PropertyType = propertyInfo.DeclaringType the assertion reports the property type as the settings interface (ICaptureSettings) instead of System.String. A second test documents that the fix did not remove access to the declaring type: it stays reachable via SettingsType and PropertyInfo.DeclaringType.
guy-lud
added a commit
that referenced
this pull request
Jul 12, 2026
Docs only; no code changes. - FIX-PLAN.md (new): the prioritized, per-item fix plan from the three-part code review (architecture, tests, performance), with a progress banner. - SESSION-HANDOFF.md: replace the stale modernization-era handoff with a current one covering the review, the fixes shipped this cycle (PRs #8/#10/#11/#12), key decisions (Validations and EqualityCompererCreator held for upcoming feature work), ranked next steps, and gotchas. The push/PR recipe is kept in private notes rather than inlined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Re-lands the
BindingContext.PropertyTyperegression test ontomaster.The test was approved in #9, but #9 was stacked on the #8 branch and merged there; since #8 was squash-merged to
masterseparately, the test never reachedmaster. This cherry-picks it over. The B4 fix it guards is already onmaster(via #8), so the suite is green.Test —
Tests/.../SimpleSettings/BindingContextTests.cs..._IsThePropertysOwnType— a customISectionBindercaptures the per-propertyBindingContext; assertsPropertyTypeis the property's type (string/int), not the declaring interface...._StillExposesDeclaringInterface— the declaring type stays reachable viaSettingsTypeandPropertyInfo.DeclaringType.dotnet testfromsrc/→ 92 green (net8.0 + net10.0).