Fix ExistsForAll namespace typo in the Binders package - #11
Merged
Conversation
CommandLineSettingsBinder was declared in `ExistsForAll.SimpleSettings.Binders` (extra "s") while every sibling type and the package's other binders live in `ExistForAll.SimpleSettings.Binders`, forcing consumers to import two namespaces for one package. Aligns the type and the project's RootNamespace, and drops the now-redundant using in SettingsBuilderFactoryExtensions. Breaking (public namespace change), done intentionally while pre-2.0.0-stable. Build + tests green on net8.0 + net10.0.
guy-lud
added a commit
that referenced
this pull request
Jul 12, 2026
Docs only; no code changes. - FIX-PLAN.md (new): the prioritized, per-item fix plan from the three-part code review (architecture, tests, performance), with a progress banner. - SESSION-HANDOFF.md: replace the stale modernization-era handoff with a current one covering the review, the fixes shipped this cycle (PRs #8/#10/#11/#12), key decisions (Validations and EqualityCompererCreator held for upcoming feature work), ranked next steps, and gotchas. The push/PR recipe is kept in private notes rather than inlined.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the
ExistsForAll→ExistForAllnamespace typo in the Binders package.CommandLineSettingsBinderwas declared inExistsForAll.SimpleSettings.Binders(extra "s"), while every other type in the package —ConfigurationBinder,EnvironmentVariableBinder, the options types,SettingsBuilderFactoryExtensions— lives inExistForAll.SimpleSettings.Binders. Consumers had to import two nearly-identical namespaces to use one package.Changes
CommandLineSettingsBindernamespace →ExistForAll.SimpleSettings.Binders<RootNamespace>in the project file →ExistForAll.SimpleSettings.Bindersusing ExistsForAll.SimpleSettings.Binders;inSettingsBuilderFactoryExtensionsNotes
v*tag yet).dotnet testgreen on net8.0 + net10.0.Part of the review fix plan (Phase 2). The dead-code items (Validations, EqualityCompererCreator) are intentionally left in place for upcoming feature work.