Skip to content

Fix start/end chars for empty and out-of-bounds spans#8816

Merged
svlandeg merged 1 commit into
explosion:masterfrom
adrianeboyd:bugfix/out-of-bounds-spans-8767
Aug 2, 2021
Merged

Fix start/end chars for empty and out-of-bounds spans#8816
svlandeg merged 1 commit into
explosion:masterfrom
adrianeboyd:bugfix/out-of-bounds-spans-8767

Conversation

@adrianeboyd

Copy link
Copy Markdown
Contributor

Description

Fix start/end chars for empty and out-of-bounds spans

Types of change

Bug fix.

Checklist

  • I have submitted the spaCy Contributor Agreement.
  • I ran the tests, and all new and existing tests passed.
  • My changes don't require a change to the documentation, or if they do, I've added all required information.

@adrianeboyd adrianeboyd added bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects labels Jul 27, 2021
@svlandeg

svlandeg commented Aug 2, 2021

Copy link
Copy Markdown
Contributor

Definitely better & cleaner!

@svlandeg
svlandeg merged commit fbbbda1 into explosion:master Aug 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Bugs and behaviour differing from documentation feat / doc Feature: Doc, Span and Token objects

Projects

None yet

Development

Successfully merging this pull request may close these issues.

span equality is wrong when creating a span from out of bounds of doc

2 participants