CI: fix macOS and Windows builds#416
Merged
Merged
Conversation
Constraints: - `macos-latest` is now ARM64. - Python 3.11 is the first macOS ARM release available in the action. So, we use macos-13 for older versions and stop unconditionally setting the architecture to x86, so that `macos-latest` uses ARM64 builds.
danieldk
force-pushed
the
bugfix/ci-errors
branch
from
April 25, 2024 11:46
8055562 to
5c0e3da
Compare
Until pytorch/pytorch#124897 is resolved.
danieldk
changed the title
danieldk
marked this pull request as ready for review
April 25, 2024 13:01
svlandeg
approved these changes
Apr 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
There were two unrelated issues in CI builds fixed by this PR.
macos-latestis now ARM64, but we were forcefully setting x86. x86 can run on ARM64 through Rosetta, but a library was missing. Always build for the native platform instead.Types of change
Bug fixes.
Checklist