feat!: move knex loaders into entity-database-adapter-knex package#410
Conversation
This was referenced Feb 1, 2026
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## wschurman/01-30-chore_move_knex-specific_loader_logic_out_of_entitydatamanager #410 +/- ##
=================================================================================================================
Coverage 100.00% 100.00%
=================================================================================================================
Files 97 103 +6
Lines 13171 13590 +419
Branches 665 652 -13
=================================================================================================================
+ Hits 13171 13590 +419
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wschurman
force-pushed
the
wschurman/01-31-feat_move_knex_loaders_into_entity-database-adapter-knex_package
branch
9 times, most recently
from
c14d00f to
9f97b92
Compare
wschurman
force-pushed
the
wschurman/01-31-feat_move_knex_loaders_into_entity-database-adapter-knex_package
branch
from
9f97b92 to
648de2b
Compare
wschurman
force-pushed
the
wschurman/01-30-chore_move_knex-specific_loader_logic_out_of_entitydatamanager
branch
from
0be9f1d to
733b363
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Part 3 of #407.
How
This is the main PR of the stack. It creates a mechanism for "installing" the extension methods on required objects, and then installs them and tests them.
The goal is to make it better self-contained about what is core in the library and guaranteed to be efficient (dataloader'd and cached) and what is not (raw SQL and SQLFragment loads in a future PR).
This is becoming more critical in a time of agentic coding where having a discrete set of loaders that can be linted separately and instruct agents to run
EXPLAIN ANALYZEin raw cases.Test Plan
Full test coverage.