feat: add entity-database-adapter-knex-testing-utils containing StubPostgresDatabaseAdapter#412
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## wschurman/02-01-chore_add_claude.md_and_disallow_test.skip #412 +/- ##
=============================================================================================
Coverage 100.00% 100.00%
=============================================================================================
Files 103 106 +3
Lines 13590 13941 +351
Branches 1125 685 -440
=============================================================================================
+ Hits 13590 13941 +351
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
wschurman
force-pushed
the
wschurman/02-01-feat_add_entity-database-adapter-knex-testing-utils_containing_stubpostgresdatabaseadapter
branch
4 times, most recently
from
5682b58 to
0e47362
Compare
wschurman
force-pushed
the
wschurman/02-01-feat_add_entity-database-adapter-knex-testing-utils_containing_stubpostgresdatabaseadapter
branch
from
0e47362 to
083cd59
Compare
wschurman
force-pushed
the
wschurman/02-01-chore_add_claude.md_and_disallow_test.skip
branch
from
6fd729f to
48e63e9
Compare
…ostgresDatabaseAdapter
wschurman
force-pushed
the
wschurman/02-01-feat_add_entity-database-adapter-knex-testing-utils_containing_stubpostgresdatabaseadapter
branch
from
083cd59 to
fe53e07
Compare
wschurman
force-pushed
the
wschurman/02-01-chore_add_claude.md_and_disallow_test.skip
branch
from
48e63e9 to
4d8492f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
As of moving raw and conjunction loading into the
entity-database-adapter-knexpackage, the stub database adapater is no longer as useful in applications that use the package (it used to support conjunction loading synthetically for unit tests).How
This PR adds a new package,
entity-database-adapter-knex-testing-utilsthat provides what StubDatabaseAdapter used to be (it has conjunction loading).The idea is that applications that use
entity-database-adapter-knexwill use this package for their stub database needs and unit test companion provider.Test Plan
Full test coverage.