feat!: Add sql template and loader method#414
Open
wschurman wants to merge 1 commit intowschurman/02-01-feat_add_codemod_for_upcoming_v0.55.0-v0.56.0from
Open
Conversation
Member
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
cba5a4b to
fa53992
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## wschurman/02-01-feat_add_codemod_for_upcoming_v0.55.0-v0.56.0 #414 +/- ##
================================================================================================
Coverage 100.00% 100.00%
================================================================================================
Files 106 108 +2
Lines 13941 14785 +844
Branches 1205 1302 +97
================================================================================================
+ Hits 13941 14785 +844
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
4d4d971 to
fe4ee5c
Compare
ceba08f to
da8f011
Compare
fe4ee5c to
1c65da3
Compare
ide
reviewed
Feb 4, 2026
packages/entity-database-adapter-knex/src/EnforcingKnexEntityLoader.ts
Outdated
Show resolved
Hide resolved
ide
reviewed
Feb 4, 2026
ide
reviewed
Feb 4, 2026
ide
reviewed
Feb 4, 2026
ide
reviewed
Feb 4, 2026
packages/entity-database-adapter-knex/src/BasePostgresEntityDatabaseAdapter.ts
Outdated
Show resolved
Hide resolved
1c65da3 to
eea3a17
Compare
da8f011 to
39f26e6
Compare
eea3a17 to
098ab02
Compare
098ab02 to
cbd366a
Compare
ide
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Why
This is the first new feature afforded by the changes in #407.
It adds a feature that is fairly common amongst typescript ORMs: sql via tagged templates for safe value interpolation into SQL statements.
How
Quite a lot of ORMs have this:
This adds support for it to entity knex.
See tests for examples, especially
PostgresEntityIntegration-test.ts.The idea is that this will replace
loadManyByRawWhereClauseAsyncover the course of a few versions.Test Plan
Full test coverage.