Skip to content

Conversation

@step-security-bot
Copy link
Contributor

@step-security-bot step-security-bot commented May 17, 2025

Summary

This pull request is created by StepSecurity at the request of @UlisesGascon. Please merge the Pull Request to incorporate the requested changes. Please tag @UlisesGascon on your message if you have any questions related to the PR.
Related expressjs/security-wg#2

Security Fixes

Least Privileged GitHub Actions Token Permissions

The GITHUB_TOKEN is an automatically generated secret to make authenticated calls to the GitHub API. GitHub recommends setting minimum token permissions for the GITHUB_TOKEN.

Keeping your actions up to date with Dependabot

With Dependabot version updates, when Dependabot identifies an outdated dependency, it raises a pull request to update the manifest to the latest version of the dependency. This is recommended by GitHub as well as The Open Source Security Foundation (OpenSSF).

Detect Vulnerabilities with SAST Workflow

Static Code Analysis (also known as Source Code Analysis) is usually performed as part of a Code Review (also known as clear-box testing) and is carried out at the Implementation phase of a Security Development Lifecycle (SDL). Static Code Analysis commonly refers to the running of Static Code Analysis tools that attempt to highlight possible vulnerabilities within ‘static’ (non-running) source code by using techniques such as Taint Analysis and Data Flow Analysis.

Secure Dockerfiles

Pin image tags to digests in Dockerfiles. With the Docker v2 API release, it became possible to use digests in place of tags when pulling images or to use them in FROM lines in Dockerfiles.

Add OpenSSF Scorecard Workflow

OpenSSF Scorecard is an automated tool that assesses a number of important heuristics ("checks") associated with software security and assigns each check a score of 0-10. You can use these scores to understand specific areas to improve in order to strengthen the security posture of your project.

Scorecard workflow also allows maintainers to display a Scorecard badge on their repository to show off their hard work.

Feedback

For bug reports, feature requests, and general feedback; please email support@stepsecurity.io. To create such PRs, please visit https://app.stepsecurity.io/securerepo.

Signed-off-by: StepSecurity Bot bot@stepsecurity.io

Signed-off-by: StepSecurity Bot <bot@stepsecurity.io>
@step-security-bot step-security-bot requested review from a team as code owners May 17, 2025 14:45
@netlify
Copy link

netlify bot commented May 17, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit ab09845
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/683670abf3946f0008d9828b
😎 Deploy Preview https://deploy-preview-1905--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@bjohansebas
Copy link
Member

While we're at it, I'm going to pin the setup/ruby action

@bjohansebas
Copy link
Member

By the way, don’t merge this until #1874 is merged. There’s no rush to merge this, since if it gets merged now, we’d have to redo the necessary changes in #1874.

@bjohansebas bjohansebas added the blocked PRs that are blocked by other issues or PRs label May 18, 2025
Signed-off-by: Sebastian Beltran <bjohansebas@gmail.com>
@bjohansebas
Copy link
Member

For @expressjs/docs-wg, always leave a comment stating that you’ve verified the hashes of the actions updated by dependabot. If that’s not done, the PR shouldn’t be merged.

ref: https://github.com/expressjs/discussions/blob/master/docs/adr/366-action-pinning.md

@bjohansebas bjohansebas merged commit fc56d27 into expressjs:gh-pages May 28, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked PRs that are blocked by other issues or PRs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants