fix(rust): decimal culture overloads, and mutables assigned in try/finally - #4918
Merged
Merged
Conversation
…nally - d.ToString(provider), Decimal.Parse(s, provider) and Decimal.Parse(s, style, provider) now compile. The provider was forwarded to runtime functions that have no parameter for it, so Parse reached a one-argument function and ToString put an IFormatProvider where the decimal belongs. Rust parses and formats invariantly, which is what InvariantCulture asks for, so the culture and style arguments are dropped instead - a `let mutable` assigned in a finally block was mutating a clone of its cell and silently losing the write. try/with/finally now count as the closure contexts they compile into, so the binding is ref-counted like any other captured mutable The decimal half matters beyond convenience: the culture-less Decimal.Parse compiles but throws under a comma-separator locale such as fi-FI, so a library storing a decimal as text had no supported way to read it back.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
let mutableassigned in a finally block was mutating a clone of its cell and silently losing the write. try/with/finally now count as the closure contexts they compile into, so the binding is ref-counted like any other captured mutableThe decimal half matters beyond convenience: the culture-less Decimal.Parse compiles but throws under a comma-separator locale such as fi-FI, so a library storing a decimal as text had no supported way to read it back.