feat(all): Quotations: DerivedPatterns, and captured locals as Value nodes - #4919
Merged
ncave merged 2 commits intoSep 1, 2026
Merged
Conversation
…nodes - AndAlso, OrElse and SpecificCall are mapped, with an implementation in each runtime that has a quotation module. They were the last patterns still reporting "not supported by Fable", and && and || desugar into IfThenElse, so without them a consumer has to re-derive that shape by hand - a local captured by a quotation is now spliced in as a Value holding its value, the way .NET does, instead of a Var carrying only a name. That needed three changes together: the emitter tracks which names the quotation binds, getSubExpressions lets analysis see into a Quote, and canInlineArg stops removing a binding whose only reference lives inside one
ncave
self-requested a review
September 1, 2026 13:15
ncave
approved these changes
Sep 1, 2026
Collaborator
|
LGTM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
runtime that has a quotation module. They were the last patterns still
reporting "not supported by Fable", and && and || desugar into IfThenElse, so
without them a consumer has to re-derive that shape by hand
value, the way .NET does, instead of a Var carrying only a name. That needed
three changes together: the emitter tracks which names the quotation binds,
getSubExpressions lets analysis see into a Quote, and canInlineArg stops
removing a binding whose only reference lives inside one