Propagate generator kwargs to transfer-learning fallback (#5277) - #5277
Open
saitcakmak wants to merge 2 commits into
Open
Propagate generator kwargs to transfer-learning fallback (#5277)#5277saitcakmak wants to merge 2 commits into
saitcakmak wants to merge 2 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@saitcakmak has exported this pull request. If you are a Meta employee, you can view the originating Diff in D116468995. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5277 +/- ##
=======================================
Coverage 96.58% 96.58%
=======================================
Files 621 621
Lines 70852 70867 +15
=======================================
+ Hits 68434 68449 +15
Misses 2418 2418 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
meta-codesync
Bot
changed the title
saitcakmak
added a commit
to saitcakmak/Ax
that referenced
this pull request
Aug 18, 2026
Summary: Pass `additional_generator_kwargs` to the single-task fallback so shared acquisition behavior such as BONSAI pruning applies regardless of model selection. Document that the kwargs must be compatible with both generators and add constructor coverage. Differential Revision: D116468995
saitcakmak
force-pushed
the
export-D116468995
branch
from
August 18, 2026 18:12
f41c1f8 to
ed34cea
Compare
…k#5278) Summary: Convert the contour trace `x`, `y`, and `z` values to plain Python lists before Plotly serialization. This prevents Plotly 6 from preserving NumPy-backed values as base64 typed-array dictionaries when `PlotlyAnalysisCard.get_figure()` reconstructs the figure. Fixes OSS CI failures caused by the previous diff. These didn't surface in internal infra due to different plotly versions used. Differential Revision: D116474354
Summary: Pass `additional_generator_kwargs` to the single-task fallback so shared acquisition behavior such as BONSAI pruning applies regardless of model selection. Document that the kwargs must be compatible with both generators and add constructor coverage. Differential Revision: D116468995
saitcakmak
force-pushed
the
export-D116468995
branch
from
August 18, 2026 18:37
ed34cea to
451d179
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Pass
additional_generator_kwargsto the single-task fallback so shared acquisition behavior such as BONSAI pruning applies regardless of model selection. Document that the kwargs must be compatible with both generators and add constructor coverage.Differential Revision: D116468995