Adding Code of Conduct file - #1
Merged
Merged
Conversation
meta-cla
Bot
added
the
CLA Signed
This was referenced Mar 15, 2026
5 tasks
Merged
This was referenced Mar 20, 2026
This was referenced Mar 22, 2026
This was referenced Apr 12, 2026
cixzhang
added a commit
that referenced
this pull request
Apr 26, 2026
…of_conduct_file_exists Adding Code of Conduct file
This was referenced May 29, 2026
josephfarina
added a commit
that referenced
this pull request
Jun 1, 2026
The global --lang flag is advertised on every subcommand's help (declared
on the root program), but only component/hook/discover/docs translate.
Write/action commands (init, template, theme, upgrade, swizzle, build,
gap-report) silently ignored it and produced English.
Add a global preAction hook that validates --lang / --zh / --dense before
any side effects:
- unsupported locale -> exit 1 (or structured { error } under --json)
- partially-translated locale (zh) -> exit 0 + one-time stderr warning
- --lang combined with legacy --zh/--dense -> exit 1 (ambiguous)
init --all --lang xx now exits 1 with zero files written (no half-writes).
Adds 9 subprocess/e2e tests proving the behavior across read and write
commands, the --json contract, side-effect-free rejection, and i18n honesty.
Closes checklist items #1 (flag validation) and #10 (i18n honesty) for the
write/action commands not covered by #2407.
cixzhang
pushed a commit
that referenced
this pull request
Jun 29, 2026
* fix(core): add role=tooltip to the Tooltip layer Addresses #3240. The Tooltip floating layer had no role, so it didn't complete the ARIA tooltip pattern (trigger already sets aria-describedby to the layer id) and test tooling had no stable selector for it. Add an optional role on the layer render props and pass role='tooltip' from useTooltip. +test asserting role + the aria-describedby link. Scoped to the Tooltip role (issue's #1 priority). HoverCard role, data-state, and data-testid forwarding are noted as follow-ups. * fix(core): add role=dialog to HoverCard layer + trim changeset Addresses review feedback on #3243 (@Daniel15): - Add role='dialog' to the HoverCard floating layer (Popover already exposes role='dialog' via usePopover). - Trim the changeset's 'stable selector' clause (role stability can be assumed). +test asserting HoverCard layer role='dialog'. --------- Co-authored-by: Durvesh Pilankar <durveshpilankar@meta.com>
This was referenced Jul 1, 2026
humbertovirtudes
added a commit
to humbertovirtudes/astryx
that referenced
this pull request
Jul 12, 2026
Address review feedback (cixzhang, ernestt) and self-review findings:
- Rename result field getRowKey -> idKey for parallelism with the Table prop
(cixzhang): <Table idKey={grouped.idKey} />. Config input stays `getRowKey`.
- Fix O(n^2) row keying (self-review): the positional fallback used
flattened.indexOf(item) per row. Prebuild an item->index Map once per
flattened array so key lookup is O(1) — O(n^2) -> O(n) for the whole table.
- Chevron alignment (ernestt facebook#1): the chevron is a standalone, chrome-less
button flush with the table's leading edge (no heavy button background),
still keyboard-operable; the whole header row remains a click convenience.
- Divider (ernestt facebook#2): add a bottom border beneath each group header row.
- Typography (ernestt facebook#3): the group label uses emphasized body (semibold at
body size), not a larger text size; count is regular weight.
- Tests (10, all green): add renderGroupHeader coverage, empty-data,
collapse-persistence-across-data-change (count updates, stays collapsed),
toggle-and-back, aria-expanded on the header row, and a named keyboard-
operable toggle button.
Tags: ai-generated
This diff was generated with AI assistance (Navi). The implementation and
tests were produced by an AI agent; the human author reviewed and approved
the changes.
humbertovirtudes
added a commit
that referenced
this pull request
Jul 14, 2026
* feat(core): add useTableGroupedRows plugin
Groups a flat data array into collapsible section rows. Each distinct
groupBy value becomes a full-width section-header row with a chevron
toggle, group label, and member count; collapsing hides that group's rows
while keeping the header visible.
- Mirrors useTableRowExpansionState: consumer owns the collapsedGroups set;
the hook returns {data, plugin, getRowKey} — pass to Table data/plugins/idKey.
- Supports renderGroupHeader (custom header content) and groupOrder.
- Synthetic header rows are Proxy-wrapped so user cell renderers can't throw
on them before transformBodyRow replaces the row with a full-width cell.
- Storybook stories (default, initially-collapsed, custom order/header),
docsite hook doc + example block, unit tests, and a Table Lab toggle.
* feat(core): idKey output, O(n) keying, UI polish for useTableGroupedRows
Address review feedback (cixzhang, ernestt) and self-review findings:
- Rename result field getRowKey -> idKey for parallelism with the Table prop
(cixzhang): <Table idKey={grouped.idKey} />. Config input stays `getRowKey`.
- Fix O(n^2) row keying (self-review): the positional fallback used
flattened.indexOf(item) per row. Prebuild an item->index Map once per
flattened array so key lookup is O(1) — O(n^2) -> O(n) for the whole table.
- Chevron alignment (ernestt #1): the chevron is a standalone, chrome-less
button flush with the table's leading edge (no heavy button background),
still keyboard-operable; the whole header row remains a click convenience.
- Divider (ernestt #2): add a bottom border beneath each group header row.
- Typography (ernestt #3): the group label uses emphasized body (semibold at
body size), not a larger text size; count is regular weight.
- Tests (10, all green): add renderGroupHeader coverage, empty-data,
collapse-persistence-across-data-change (count updates, stays collapsed),
toggle-and-back, aria-expanded on the header row, and a named keyboard-
operable toggle button.
Tags: ai-generated
This diff was generated with AI assistance (Navi). The implementation and
tests were produced by an AI agent; the human author reviewed and approved
the changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is pull request was created automatically because we noticed your project was missing a Code of Conduct file.
CODE_OF_CONDUCT files facilitate respectful and constructive communities by establishing expected behaviors for project contributors.
This PR was crafted with love by Meta's Open Source Team.