Conversation
meta-cla
Bot
added
the
CLA Signed
This was referenced May 29, 2026
josephfarina
added a commit
that referenced
this pull request
Jun 1, 2026
The global --lang flag is advertised on every subcommand's help (declared
on the root program), but only component/hook/discover/docs translate.
Write/action commands (init, template, theme, upgrade, swizzle, build,
gap-report) silently ignored it and produced English.
Add a global preAction hook that validates --lang / --zh / --dense before
any side effects:
- unsupported locale -> exit 1 (or structured { error } under --json)
- partially-translated locale (zh) -> exit 0 + one-time stderr warning
- --lang combined with legacy --zh/--dense -> exit 1 (ambiguous)
init --all --lang xx now exits 1 with zero files written (no half-writes).
Adds 9 subprocess/e2e tests proving the behavior across read and write
commands, the --json contract, side-effect-free rejection, and i18n honesty.
Closes checklist items #1 (flag validation) and #10 (i18n honesty) for the
write/action commands not covered by #2407.
kentonquatman
added a commit
that referenced
this pull request
Jul 25, 2026
The inset hairline drawn over the image switches from the theme-tinted --color-border token to a neutral translucent edge: rgba(0,0,0,.0625) (#10) in light mode and rgba(255,255,255,.25) (#FFFFFF40) in dark mode, via light-dark(). This reads consistently across images and themes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need this dependency so let's remove it.