Skip to content

Rename built-in syntax theme identifiers - #5755

Closed
rubyycheung wants to merge 1 commit into
codex/neutral-theme-gold-star-colorsfrom
codex/neutral-syntax-theme-name
Closed

Rename built-in syntax theme identifiers#5755
rubyycheung wants to merge 1 commit into
codex/neutral-theme-gold-star-colorsfrom
codex/neutral-syntax-theme-name

Conversation

@rubyycheung

Copy link
Copy Markdown
Contributor

Summary

  • renames the Neutral syntax theme id from xds-neutral to astryx-neutral
  • updates the generated CLI Neutral theme template to match

Notes

  • This does not rename the main Neutral theme; it only changes the syntax-theme identifier used for code highlighting.

Validation

  • pnpm -F @astryxdesign/theme-neutral build
  • pre-commit checks from commit hook

@vercel

vercel Bot commented Aug 31, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
astryx Ready Ready Preview Aug 31, 2026 6:04am

Request Review

@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Aug 31, 2026
@rubyycheung
rubyycheung force-pushed the codex/neutral-theme-gold-star-colors branch from 6082b6f to 5940255 Compare August 31, 2026 05:35
@rubyycheung
rubyycheung force-pushed the codex/neutral-syntax-theme-name branch from f98f95e to b6df165 Compare August 31, 2026 05:36
@rubyycheung
rubyycheung force-pushed the codex/neutral-theme-gold-star-colors branch from 5940255 to 4e3970c Compare August 31, 2026 05:43
@rubyycheung
rubyycheung force-pushed the codex/neutral-syntax-theme-name branch 2 times, most recently from 31e4a42 to 8e17f1c Compare August 31, 2026 05:46
@rubyycheung
rubyycheung force-pushed the codex/neutral-theme-gold-star-colors branch from 4e3970c to 9267613 Compare August 31, 2026 05:49
@rubyycheung
rubyycheung force-pushed the codex/neutral-syntax-theme-name branch from 8e17f1c to cac1aa6 Compare August 31, 2026 05:50
@rubyycheung
rubyycheung force-pushed the codex/neutral-syntax-theme-name branch 2 times, most recently from e97d020 to d882c1b Compare August 31, 2026 05:57
@rubyycheung rubyycheung changed the title Rename Neutral syntax theme identifier Rename built-in syntax theme identifiers Aug 31, 2026
@rubyycheung
rubyycheung force-pushed the codex/neutral-theme-gold-star-colors branch from 9267613 to ceabacf Compare August 31, 2026 06:00

@cixzhang cixzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up the XDS names. Published theme objects and CSS stay identical; astryx theme add now emits matching Astryx-prefixed source.

[Reviewed by Robohands]

@rubyycheung

Copy link
Copy Markdown
Contributor Author

Superseded by #5847, which contains the same approved syntax-theme identifier cleanup on a standalone branch based directly on main.

This removes the accidental dependency on the retired mixed Neutral PR #5752. The original approval and discussion remain preserved here.

@rubyycheung rubyycheung closed this Sep 1, 2026
@github-actions
github-actions Bot deleted the codex/neutral-syntax-theme-name branch September 2, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants