Skip to content

Rename built-in syntax theme identifiers - #5847

Merged
cixzhang merged 1 commit into
mainfrom
codex/syntax-theme-identifiers
Sep 2, 2026
Merged

Rename built-in syntax theme identifiers#5847
cixzhang merged 1 commit into
mainfrom
codex/syntax-theme-identifiers

Conversation

@rubyycheung

Copy link
Copy Markdown
Contributor

Summary

  • rename each built-in syntax-theme identifier from the legacy XDS prefix to its Astryx theme name
  • update the generated CLI theme templates to match
  • keep published theme objects and CSS behavior otherwise unchanged

Scope

This is the standalone main-based replacement for #5755. It no longer waits behind the retired mixed Neutral PR #5752.

Validation

  • pnpm -F @astryxdesign/core build
  • pnpm -F @astryxdesign/theme-neutral build
  • pnpm check:sync
  • pnpm check:changesets

The identical change was approved by @cixzhang on #5755 before the stack was untangled.

@rubyycheung
rubyycheung requested a review from cixzhang September 1, 2026 21:09
@meta-cla meta-cla Bot added the CLA Signed This label is managed by the Meta Open Source bot. label Sep 1, 2026
@vercel

vercel Bot commented Sep 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
astryx Ready Ready Preview Sep 1, 2026 9:13pm UTC

Request Review

@github-actions

github-actions Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

PR Analysis Report

📚 Storybook Preview

View Storybook for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

🧪 Sandbox Preview

View Sandbox for this PR
GitHub Pages may take up to a minute to hydrate after deploy.

No new or modified components detected.

Bundle Size Summary

No component packages changed.

Accessibility Audit

Status: No accessibility violations detected.

Visual Regression

Status: No visual change across 4066 compared shot(s).


Generated by PR Enrichment workflow | Storybook | Sandbox | View full report

@cixzhang cixzhang left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for separating this cleanup. The seven published theme objects and CSS remain byte-identical; generated theme source now uses Astryx-prefixed syntax names.

[Reviewed by Robohands]

@cixzhang
cixzhang merged commit 4357d28 into main Sep 2, 2026
27 checks passed
@github-actions
github-actions Bot deleted the codex/syntax-theme-identifiers branch September 2, 2026 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CLA Signed This label is managed by the Meta Open Source bot.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants