break: migrate from Eta v2 to v4 - #12404
Merged
Merged
Conversation
slorber
added
the
pr: breaking change
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
slorber
added
the
Argos
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Breaking
For users using the
siteConfig.ssrTemplateoption (probably not many), the Eta syntax might have changed a bit. Eta releases do not explicitly document the changes.Motivation
Maintenance upgrade
Changelogs of major version bumps:
The Eta API is used internally, so API breaking changes are not important for users.
It's not clear what the breaking changes are in terms of the syntax template, but most Docusaurus users probably do not provide a custom SSR template and apparently the impact is quite limited:
I'll still consider this a breaking change, but we don't really have more details to mention apart from reading the Eta docs.
See the syntax doc: https://eta.js.org/docs/4.x.x/syntax/template-syntax
Test Plan
CI
Test links
Deploy preview: https://deploy-preview-12404--docusaurus-2.netlify.app/