chore: migrate from chalk to node.utils.styleText() - #12405
Merged
Conversation
slorber
added
the
pr: maintenance
✅ [V2]
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Size Change: 0 B Total Size: 12.3 MB ℹ️ View Unchanged
|
⚡️ Lighthouse report for the deploy preview of this PR
|
|
Size Change: 0 B Total Size: 12.5 MB ℹ️ View Unchanged
|
slorber
added
the
Argos
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
For our basic usage, we don't need a dependency anymore to style console outputs, Nodejs supports this natively: https://nodejs.org/api/util.html#utilstyletextformat-text-options
Unfortunately, we still have chalk as a transitive dependency, but still useful to remove it.
Note: encountered a
styleText()coloring problem in SSG worker threads. This is mostly for our internal perf logger coloring during SSG, not really a user-facing problem. I added a workaround, and reported the problem to Node.js in nodejs/node#65766Test Plan
CI + local tests
Test links
https://deploy-preview-12405--docusaurus-2.netlify.app/