Add constant highlighting for ALL_CAPS variables - #1832
Closed
AryanBagade wants to merge 1 commit into
Closed
Conversation
Contributor
|
cool! thanks for the research and exhaustive test plan |
kinto0
approved these changes
Dec 12, 2025
Contributor
yangdanny97
approved these changes
Dec 12, 2025
yangdanny97
left a comment
yangdanny97
left a comment
Contributor
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1780
Summary
Configure VSCode extension and web sandbox to highlight constants (ALL_CAPS variables) in a distinct teal color. The backend already detects ALL_CAPS variables as constants and sends the
readonlymodifier - this change ensures they're visually distinguished in both the VSCode extension and the pyrefly.org sandbox.Test Plan
sandbox ui
vscode
