Send custom FuseboxClient.setClientMetadata message on load #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Mar 20, 2024
Summary: Changelog: [Internal] Uses facebook/react-native-devtools-frontend#24 to identify the Fusebox frontend and show a corresponding message in the logs. Also tweaks the wording and formatting of other messages logged by the Fusebox backend - including removing the "you are using the modern CDP backend" one. Reviewed By: huntie Differential Revision: D55075645
motiz88
added a commit
to motiz88/react-native
that referenced
this pull request
Mar 20, 2024
…end (facebook#43565) Summary: Changelog: [Internal] Uses facebook/react-native-devtools-frontend#24 to identify the Fusebox frontend and show a corresponding message in the logs. Also tweaks the wording and formatting of other messages logged by the Fusebox backend - including removing the "you are using the modern CDP backend" one. Reviewed By: huntie Differential Revision: D55075645
robhogan
approved these changes
Mar 20, 2024
facebook-github-bot
pushed a commit
to facebook/react-native
that referenced
this pull request
Mar 20, 2024
…end (#43565) Summary: Pull Request resolved: #43565 Changelog: [Internal] Uses facebook/react-native-devtools-frontend#24 to identify the Fusebox frontend and show a corresponding message in the logs. Also tweaks the wording and formatting of other messages logged by the Fusebox backend - including removing the "you are using the modern CDP backend" one. Reviewed By: huntie Differential Revision: D55075645 fbshipit-source-id: c82670570c79b61efd399f26684139ce97f017ef
2 tasks
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Registers a trivial
FuseboxClientMetadataModelas part of thern_inspectorentry point, which sends a custom CDP message (FuseboxClient.setClientMetadata) when connected.This is intended to allow the modern React Native CDP backend to positively identify this frontend. We do this for display purposes only, as React Native aims to keep overall compatibility with CDP. We forgo setting up a proper CDP domain and agent, with codegen and types, because we don't anticipate extending this solution much further.
Test plan
Manually confirmed that the message reaches the backend on first connection and on reload/reconnection.
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.