Migrate FuseboxClient domain to a codegenned agent #64
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Previously (#24) we added the
FuseboxClient.setClientMetadatamethod as an ad-hoc protocol extension directly inrn_fusebox.ts. Here we formalise this protocol extension by using the CDP codegen mechanism available in the repo. This is in anticipation of adding more React Native-specific methods/events in the future.How to add RN-specific protocol messages
Upstream docs for the codegen mechanism are available here. In practice, I only followed the steps that are relevant to the CDT repo, skipping the Chromium ones.
For ease of rebasing in the future, I've created a new
react_native_domains.pdlfile instead of modifying the existingbrowser_protocol.pdl.Test plan
TODO: Ensure that the correct Fusebox welcome message appears on startup.
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.