Add app name and device name to window title #87
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Note
Depends on #86 and facebook/react-native#45250.
Updates the
rn_fuseboxentrypoint to update the window title if the device returns identifying metadata viaReactNativeApplication.metadataUpdated. This signals the current app name and device name to the user! 🎉Resolves T165849560.
Note
Known issue —
ReactNativeApplicationModelis mounted within the Welcome panel, meaning this behaviour won't trigger if opened to another panel. This needs to be relocated in a later PR — likely having some model within the entrypoint inherit from this (or however the data flow can work). However, I want to land this change (see #88 for where we do make use of this inRNWelcome.ts) so we have incremental progress.Test plan
Connect to Android and iOS after facebook/react-native#45250.
Upstreaming plan
devtools-frontendrepo. I've reviewed the contribution guide.