Skip to content

Conversation

@huntie
Copy link
Member

@huntie huntie commented Jul 2, 2024

Summary

Defines and generates types for our custom ReactNativeApplication CDP domain:

  • ReactNativeApplication.enable
  • ReactNativeApplication.disable
  • ReactNativeApplication.metadataUpdated

This was done previously for FuseboxClient in #64.

This change will support displaying host metadata in the frontend, see #87 and #88.

Test plan

npm run build

This change is load bearing in stacked PRs.

Upstreaming plan

  • This commit should be sent as a patch to the upstream devtools-frontend repo. I've reviewed the contribution guide.
  • This commit is React Native-specific and cannot be upstreamed.

@hoxyq
Copy link

hoxyq commented Jul 3, 2024

Should we move 'FuseboxClient.setClientMetadata' to 'ReactNativeApplication.setClientMetadata'?

@huntie huntie force-pushed the rnapp-cdp-types branch from 9d729fd to 055ba49 Compare July 3, 2024 14:51
@huntie huntie merged commit eeb767d into facebook:main Jul 3, 2024
@huntie huntie deleted the rnapp-cdp-types branch July 3, 2024 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants